906549 - [Flatfish][LockScreen] add support for large device for portrait

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: LockScreen_P.png

Expect:

Modify and Merge experiment tablet work from 

https://github.com/gaia-local/gaia

to master

----
Note: Since orientation in large device is not ready yet, we fire separate bugs for landscape and portrait to not block the development progress

Comment 1

[Francis Lee [:frlee]]

It's a must for flatfish. Marked as koi+ according to triage result.

Comment 2

[[e-mail]]

--- Since the basic layout works and 1.2 is target for minimum tablet support

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

I needinfo Patryk here for the 1.5X and 2.0X arrow bitmap used in the lockscreen, and would fixed the bug after our lockscreens use them to replace the old 1.0X image under larger resolution.

Comment 4

[Patryk Adamczyk [:patryk] UX]

We don't support 2x size. I believe those arrows were vector.
Przemek, can you comment / if needed provide the 1.5x graphics?

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

Today I got the 1.5X arrow image, so clear the needinfo here.

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

UX provide us the new 1.5X image.
And according to the mail, there's no 2.0X image at all.

I want to close the LockScreen bugs related to Flatfish. The landscape one had been closed due to one CSS adjustment, so this one can be the last step to finish these bugs.

Comment 7

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/6d42c3ec5565bb1f07e0aa5d0c7ca2df6b35a161

Comment 8

[[e-mail]]

Comment on attachment 821555 [details] [review]
Patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment] image update only
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 9

[Preeti Raghunath(:Preeti)]

Please complete the user impact if declined.

Comment 10

[[e-mail]]

Comment on attachment 821555 [details] [review]
Patch

after recheck, I think it's more like 1.1hd bug

Comment 11

[[e-mail]]

1.10hd not use new lockscreen style, so not need to uplift it. thanks

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I pushed 7374a741fc056860331dd0511a260081107f7921 so we could see this image in it's correct size.

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 821555 [details] [review]
Patch

This needs to go to v1.2 (along with what I pushed) because we need to maintain support to helix in v1.2 branch.

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.2: d0266d6f9b8fa15deb710389db2b282699cb2308
v1.2: 670b2c8329bca6f142939185be71274166d82bb8

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

The master commits are already on v1.3