906629 - B2G MMS: Wrong callback function on |retrieve| in MmsService.js

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

We put the wrong callback function on |retrieve| in MmsService.js. It will cause wrong code flow sequence.

Comment 1

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: bug-906629.patch-v1.0

Comment 2

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: bug-906629.patch-v1.1

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 792116 [details] [diff] [review]
bug-906629.patch-v1.1

Review of attachment 792116 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

This may result in racing condition between marking the retrieving message as "pending" and marking it as "error" when we're in airplane mode, no SIM card, or any quick errors.

Comment 5

[Peter Dolanjski [:pdol]]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #4)
> This may result in racing condition between marking the retrieving message
> as "pending" and marking it as "error" when we're in airplane mode, no SIM
> card, or any quick errors.

What is the user impact of such a race condition?

Comment 6

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Can not download again until rebooted.

Comment 7

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/b2g-inbound/rev/7bc59a28d3bd

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7bc59a28d3bd

Comment 9

[Preeti Raghunath(:Preeti)]

Taking it on 18 for MMS

Comment 10

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: bug-906629-b2g18.patch

Patch for b2g18.

Comment 11

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/74914b454b88

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/74914b454b88