Closed Bug 906629 Opened 6 years ago Closed 6 years ago

B2G MMS: Wrong callback function on |retrieve| in MmsService.js

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26
blocking-b2g leo+
Tracking Status
firefox24 --- wontfix
firefox25 --- wontfix
firefox26 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix
b2g-v1.1hd --- fixed

People

(Reporter: ctai, Assigned: ctai)

References

Details

Attachments

(2 files, 1 obsolete file)

We put the wrong callback function on |retrieve| in MmsService.js. It will cause wrong code flow sequence.
Attached patch bug-906629.patch-v1.0 (obsolete) — Splinter Review
Attachment #792113 - Attachment is obsolete: true
Attachment #792116 - Flags: feedback?(vyang)
Comment on attachment 792116 [details] [diff] [review]
bug-906629.patch-v1.1

Review of attachment 792116 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!
Attachment #792116 - Flags: feedback?(vyang) → review+
This may result in racing condition between marking the retrieving message as "pending" and marking it as "error" when we're in airplane mode, no SIM card, or any quick errors.
blocking-b2g: --- → leo?
(In reply to Vicamo Yang [:vicamo][:vyang] from comment #4)
> This may result in racing condition between marking the retrieving message
> as "pending" and marking it as "error" when we're in airplane mode, no SIM
> card, or any quick errors.

What is the user impact of such a race condition?
Flags: needinfo?(vyang)
Can not download again until rebooted.
Flags: needinfo?(vyang)
https://hg.mozilla.org/mozilla-central/rev/7bc59a28d3bd
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Taking it on 18 for MMS
blocking-b2g: leo? → leo+
Patch for b2g18.
You need to log in before you can comment on or make changes to this bug.