906765 - concatfragments.rb fails on first runs

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

I see a lot of this across operating systems:

Thu Aug 15 07:37:57 -0700 2013 Puppet (err): "/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/bin/ruby" /var/lib/puppet/concat/bin/concatfragments.rb -o /var/lib/puppet/concat/_Users_cltbld_.ssh_authorized_keys/fragments.concat.out-d /var/lib/puppet/concat/_Users_cltbld_.ssh_authorized_keys returned 1 instead of one of [0]
Thu Aug 15 07:37:57 -0700 2013 /Stage[main]/Users::Builder::Setup/Ssh::Userconfig[cltbld]/Concat[/Users/cltbld/.ssh/authorized_keys]/Exec[concat_/Users/cltbld/.ssh/authorized_keys]/returns(err): change from notrun to 0 failed: "/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/bin/ruby" /var/lib/puppet/concat/bin/concatfragments.rb -o /var/lib/puppet/concat/_Users_cltbld_.ssh_authorized_keys/fragments.concat.out-d /var/lib/puppet/concat/_Users_cltbld_.ssh_authorized_keys returned 1 instead of one of [0]
Thu Aug 15 07:37:57 -0700 2013 /Stage[main]/Users::Builder::Setup/Ssh::Userconfig[cltbld]/Concat[/Users/cltbld/.ssh/authorized_keys]/Exec[concat_/Users/cltbld/.ssh/authorized_keys](err): Failed to call refresh: "/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/bin/ruby" /var/lib/puppet/concat/bin/concatfragments.rb -o /var/lib/puppet/concat/_Users_cltbld_.ssh_authorized_keys/fragments.concat.out-d /var/lib/puppet/concat/_Users_cltbld_.ssh_authorized_keys returned 1 instead of one of [0]
Thu Aug 15 07:37:57 -0700 2013 /Stage[main]/Users::Builder::Setup/Ssh::Userconfig[cltbld]/Concat[/Users/cltbld/.ssh/authorized_keys]/Exec[concat_/Users/cltbld/.ssh/authorized_keys](err): "/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/bin/ruby" /var/lib/puppet/concat/bin/concatfragments.rb -o /var/lib/puppet/concat/_Users_cltbld_.ssh_authorized_keys/fragments.concat.out-d /var/lib/puppet/concat/_Users_cltbld_.ssh_authorized_keys returned 1 instead of one of [0]

But it will work fine on the next run.  It could be as simple as a missed dependency.

Comment 1

[Justin Wood (:Callek)]

(In reply to Dustin J. Mitchell [:dustin] from comment #0)
> I see a lot of this across operating systems:
> 
> But it will work fine on the next run.  It could be as simple as a missed
> dependency.

I actually suspect this is what I warned you about elsewhere (even if I didn't word myself well). The idea of it being in a ruby plugin, means first-run needs to enable pluginsync first, and then actually sync it down, before it can actually be used.

Feel free to correct me if I'm wrong. I also really want this to not error at us somehow (even if we have a soft, "firstrun" fact we use to switch on or something)

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Looks like it's a forgotten dependency on fragments.concat.out.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

And it's not a plugin

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug906765.patch

since you spoke up :)