906837 - mach command for running webapprt chrome tests

Status: RESOLVED FIXED

(Firefox Graveyard :: Webapp Runtime, enhancement)

Description

[Myk Melez [:myk] [@mykmelez]]

There should be a mach command for running webapprt-test-chrome tests, so one can use the simpler mach syntax to run them, i.e.:

  ./mach webapprt-test-chrome webapprt/test/chrome/browser_sample.js

Which is the equivalent of:

  make -C (objdir) webapprt-test-chrome TEST_PATH=webapprt/test/chrome/browser_sample.js

Comment 1

[Marco Castelluccio [:marco]]

Attachment: mach_webapprt

I still need to test on Win and Mac.

Comment 2

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 3

[Drew Willcoxon :adw]

Comment on attachment 793085 [details] [diff] [review]
Patch

Review of attachment 793085 [details] [diff] [review]:
-----------------------------------------------------------------

The webapprt parts match the equivalent parts in testsuite-targets.mk, so looks good to me, but I don't know mach, so you should probably ask a mach person to look at this, too.

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 793085 [details] [diff] [review]
Patch

Review of attachment 793085 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mochitest/mach_commands.py
@@ +116,5 @@
> +            appname = os.path.join(self.distdir, self.substs['MOZ_MACBUNDLE_NAME'], \
> +            'Contents', 'MacOS', 'webapprt-stub' + automation.BIN_SUFFIX)
> +        else:
> +            appname = os.path.join(self.distdir, 'bin', 'webapprt-stub' + \
> +            automation.BIN_SUFFIX)

Nit: You don't need line continuations here since you are inside parens ().

Comment 5

[Marco Castelluccio [:marco]]

Attachment: Patch

Carrying r+.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/de82a0040f1a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/de82a0040f1a