906979 - I cannot force spell checking from right click context menu

Status: VERIFIED FIXED

(Core :: Spelling checker, defect)

Description

[Alice0775 White]

Attachment: sample html

Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/c8c9bd74cc40
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130819030205

See Bug 905176 Comment 10. 

Steps To Reproduce.
1. Open attached
2. Right click ant Turn on "Check Spelling"
3. Type text and space

Actual Results:
 Spell checking does not work.
 No red wavy underline appears.

Expected Results:
 Forcing spell checking should be performed for these element.

Comment 1

[[e-mail]]

This seems to affect Gecko 25 and 24 too, but not Gecko 23.

Comment 2

[[e-mail]]

Bug 674927 broke this, because input and textarea elements also use the spellcheck property, so it's no longer possible to force spelling on for them.

Comment 3

[(no longer active)]

Hmm, so I debugged this a bit, and it's not clear to me how bug 674927 could have possibly broken this.  Alice, do you mind hunting down the regression range for this, please?  I want to make sure that I'm not barking up the wrong tree.  :-)

Comment 4

[Alice0775 White]

Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/069b2adf589e
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130619 Firefox/24.0 ID:20130619134753
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/5b3196ad66f4
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130619 Firefox/24.0 ID:20130619143654
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=069b2adf589e&tochange=5b3196ad66f4

In Local Build,
Last Good: 8ed0409f36c2 -3cb61a7d5746-627c03f469d8
First Bad: f26888376433 -3cb61a7d5746-627c03f469d8

Regressed by:
 f26888376433	Aryeh Gregor — Bug 674927 - Part 3: Make the spellcheck attribute work correctly for contenteditable; r=ehsan

Comment 5

[(no longer active)]

Attachment: Patch (v1)

Oh of course...

Comment 6

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/581251a392cd

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/581251a392cd

Comment 8

[(no longer active)]

Comment on attachment 794259 [details] [diff] [review]
Patch (v1)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 674927.
User impact if declined: See comment 0.
Testing completed (on m-c, etc.): Locally
Risk to taking this patch (and alternatives if risky): Low risk
String or IDL/UUID changes made by this patch: None

Comment 9

[bhavana bajaj [:bajaj]]

Comment on attachment 794259 [details] [diff] [review]
Patch (v1)

low risk uplift for a Fx24 regression.

Comment 10

[bhavana bajaj [:bajaj]]

(In reply to Alice0775 White from comment #0)
> Created attachment 792539 [details]
> sample html
> 
> Build Identifier:
> http://hg.mozilla.org/mozilla-central/rev/c8c9bd74cc40
> Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
> ID:20130819030205
> 
> See Bug 905176 Comment 10. 
> 
> Steps To Reproduce.
> 1. Open attached
> 2. Right click ant Turn on "Check Spelling"
> 3. Type text and space
> 
> Actual Results:
>  Spell checking does not work.
>  No red wavy underline appears.
> 
> Expected Results:
>  Forcing spell checking should be performed for these element.

Alice, can you please help verify this is fixed now :) ? Thanks

Comment 11

[Alice0775 White]

(In reply to bhavana bajaj [:bajaj] from comment #10)
> (In reply to Alice0775 White from comment #0)
> > Created attachment 792539 [details]
> > sample html
> > 
> > Build Identifier:
> > http://hg.mozilla.org/mozilla-central/rev/c8c9bd74cc40
> > Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
> > ID:20130819030205
> > 
> > See Bug 905176 Comment 10. 
> > 
> > Steps To Reproduce.
> > 1. Open attached
> > 2. Right click ant Turn on "Check Spelling"
> > 3. Type text and space
> > 
> > Actual Results:
> >  Spell checking does not work.
> >  No red wavy underline appears.
> > 
> > Expected Results:
> >  Forcing spell checking should be performed for these element.
> 
> Alice, can you please help verify this is fixed now :) ? Thanks

I cannot reproduce the problem anymore on latest Nightly26.0a1.
I verified this was fixed.
http://hg.mozilla.org/mozilla-central/rev/fb2318875cd4
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130823030204

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6efa0e1a63ab
https://hg.mozilla.org/releases/mozilla-beta/rev/dc4285f36240

Comment 13

[Ioana (away)]

Verified as fixed on:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Firefox/24.0 (20130826142034)
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20100101 Firefox/25.0 (20130826004002)
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 (20130826190748)