Closed Bug 907047 Opened 11 years ago Closed 11 years ago

Promise is not defined @ resource://app/modules/DownloadsCommon.jsm:493

Categories

(Toolkit :: Downloads API, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26
Tracking Status
firefox26 --- fixed

People

(Reporter: MattN, Assigned: Paolo)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

I downloaded a PDF attachment from Gmail but when I clicked on it in the panel, it didn't open the file. Clicking the folder to open in Finder worked fine. In the browser console I saw: [23:28:31.363] Promise is not defined @ resource://app/modules/DownloadsCommon.jsm:493 That points to the following line in in openDownloadedFile: promiseShouldLaunch = Promise.resolve(true); I would guess this was caused by 896927 (since it touched that line yesterday) or at least something under bug 825588.
Attached patch The patchSplinter Review
This apparently affected opening non-executable files from the Library window. Thanks for the report!
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Attachment #792661 - Flags: review?(mnoorenberghe+bmo)
Attachment #792661 - Flags: review?(mnoorenberghe+bmo) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: