907112 - [Lockscreen] Phone can unlock in pants

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Jan Jongboom [:janjongboom] (inactive)]

The gesture for the phone to unlock is too easy. My phone got unlocked three times during the weekend. Here's how it's done...

1. Don't put the phone on standby (but in the lock screen). F.e. you just checked a notification.
2. The gesture to show the lock button is very easy. You have to move the bar like 30 pixels or something which is very easy to trigger by movement of your pants.
3. Now the lock button is visible, and stays visible because the screen is touched. A touch at the right place by your upper leg will now unlock the phone.

We should either make an unlock movement that requires a larger move, or think of something else.

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

Oh this can also happen if you get a notification that turns on the screen of course.

Comment 2

[Etienne Segonzac (:etienne)]

Attachment: Gaia PR

Here's a simple patch greatly improving this issue in my experience.

It's 2 fold:

* First |states.slideReachEnd| wasn't cleaned up properly, so *after a first unlock* double taping the area caused the phone to unlock

* Second, we now reset the detection completely when we detect a second touch (that's what iOS does by the way)

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8364369 [details] [review]
Gaia PR

\O/

Comment 4

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/2946ccc07ec28cea44994d98598b85db301edd12

Comment 5

[Etienne Segonzac (:etienne)]

I wonder if we should uplift this patch because of this:

> *after a first unlock* double taping the area causes the phone to unlock

Comment 6

[:gerard-majax]

That might also solve my bug 872035

Comment 7

[Jason Smith [:jsmith]]

(In reply to Etienne Segonzac (:etienne) from comment #5)
> I wonder if we should uplift this patch because of this:
> 
> > *after a first unlock* double taping the area causes the phone to unlock

I think that's a case that we should ask approval, but not block the release. Can you ask for 1.3 approval on this patch?

Comment 8

[Etienne Segonzac (:etienne)]

Comment on attachment 8364369 [details] [review]
Gaia PR

[User impact] if declined:
> *after a first unlock* double taping the slider area causes the phone to unlock

[Testing completed]:
Tested with and without sim lock, tested the incoming lockscreen too.

[String changes made]:
none

Comment 10

[Etienne Segonzac (:etienne)]

Uplifted to 1.3
https://github.com/mozilla-b2g/gaia/commit/526b291a7cd80f79fd66b6fc81f49ced832f9a94