Closed Bug 907160 Opened 12 years ago Closed 12 years ago

E.me user data lost after upgrade to v1.1

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

x86
macOS
defect
Not set
normal

Tracking

(blocking-b2g:leo+, firefox26 verified, b2g18 verified, b2g-v1.1hd fixed)

VERIFIED FIXED
blocking-b2g leo+
Tracking Status
firefox26 --- verified
b2g18 --- verified
b2g-v1.1hd --- fixed

People

(Reporter: ranbena, Assigned: evyatar)

References

Details

Attachments

(2 files)

E.me search history and shortcuts should persevere after upgrading OS to v1.1. A migration script must be run, after storage method change http://bugzil.la/876237
Assignee: nobody → evyatar
blocking-b2g: --- → leo?
Migration of important storage data from 1.0.1 to 1.1 - user search history and customized shortcuts. Needed because 1.0.1 uses localStorage and 1.1 IndexedDB.
Attachment #793434 - Flags: review?(crdlc)
Comment on attachment 793434 [details] Patch - redirect to github PR Good work as usual, please read some comment on Github, thanks a lot
Attachment #793434 - Flags: review?(crdlc) → review+
already fixed the comments :) great, thanks, merging to master and we'll wait for leo+.
merged into master 70033ba9cbac65551f68fcb3a28f7daf3105e6ff https://github.com/mozilla-b2g/gaia/commit/70033ba9cbac65551f68fcb3a28f7daf3105e6ff
This issue has a huge impact on our users(the ones that are now in 1.0.1), please set Leo+ flag here. Thanks!
blocking-b2g: leo? → leo+
### ENV: Unagi pvt v1.0.1 Gaia: 054cdc27404e2daca91d3065d9783681032b2151 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/9c62297d11b0 BuildID 20130822043202 Version 18.0 to http://update.boot2gecko.org/unagi/1.1.0/nightly/update.xml Gaia: a83c5fee49525ec0545059b5a56a3fd9f1c09f19 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/74914b454b88 BuildID 20130822041201 Version 18.0 ### STR: 0. Flash to v1.0.1, change OTA update URL to v1.1.0. 1. Connect to network. 2. Go to E.me page, search "youtube". 3. Long press "Youtube" E.me app, then add it to Homescreen. 4. Back to Homescreen, make sure there is "Youtube" E.me app on Homescreen. 5. Do OTA update. 6. Check the E.me search history and Homescreen. ### EXPECTED: There is "Youtube" E.me app on Homescreen and "youtube" in E.me search history. ### ACTUAL: There is "Youtube" E.me app on Homescreen. But there is NO "youtube" in E.me search history.
Askeing - your test was actually running on v1-train, and this fix is only on master. I'll update once it's fully tested and on v1-train. Thanks!
QA team/Askeing, can someone help test/verify the patch is working as expected. Thanks!
Unari v1.0.1 Gaia: 054cdc27404e2daca91d3065d9783681032b2151 B-D 2013-07-06 19:39:29 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/9c62297d11b0 BuildID 20130826043201 Version 18.0 to http://update.boot2gecko.org/unari/1.2.0/nightly/update_20130826190748.xml Gaia: 43cf923c3020d77a9fa962cc0c30fd27f647660d B-D 2013-08-27 07:49:16 Gecko: http://hg.mozilla.org/mozilla-central/rev/c0d1baa50a64 BuildID 20130826190748 Version 26.0a1 This issue does not exist on unari from 1.0.1 to 1.2.0
### ENV: Unagi pvt v1.0.1 Gaia: 054cdc27404e2daca91d3065d9783681032b2151 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/9c62297d11b0 BuildID 20130826043201 Version 18.0 To http://update.boot2gecko.org/unagi/1.2.0/nightly/update.xml Gaia: 43cf923c3020d77a9fa962cc0c30fd27f647660d Gecko: http://hg.mozilla.org/mozilla-central/rev/c0d1baa50a64 BuildID 20130826190748 Version 26.0a1 ### STR: see comment 6 Works when upgrade from unagi v1.0.1 to v1.2.0.
Askeing, is it possible for you to do the same tests for "v1.0.1 to v1.1"? We want to make sure it works well before merging it into v1-train.
Flags: needinfo?(fyen)
This fix is only on master(v1.2.0), so v1.1.0 update channels do not have this fix. Or you can provide us the patch file, then we can generate the local update package for testing.
Flags: needinfo?(fyen)
Depends on: 909631
The PR's patch file merges cleanly into v1-train https://github.com/mozilla-b2g/gaia/pull/11661.patch can you use this one, or is there a different way to create a patch specifically for v1-train?
Attached patch 11661.patchSplinter Review
Attached a patch which applies cleanly in to v1-train.
Evyatar and Ran, thank you. Here's result. ### ENV: Unagi pvt v1.0.1 Gaia: 054cdc27404e2daca91d3065d9783681032b2151 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/9c62297d11b0 BuildID 20130827043201 Version 18.0 To TW-CI build for Bug 907160 Gaia mozillaorg/v1-train - 4b2f1a103d046c92d201e8fcfb1ae224f59e7cf1 Gecko mozillaorg/gecko-18 - 61e302a35458ee70aeaaadc8c9b67d8a7943d99e ### STR: see comment 6 Works when upgrade from Unagi v1.0.1 to v1.1.0
uplifted to v1-train - v1.1 518178ca234c98eb1ca0c0997b9d59faea640a85 https://github.com/mozilla-b2g/gaia/commit/518178ca234c98eb1ca0c0997b9d59faea640a85 Askeing - can you perform the real test now on 1.1? last time :)
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: needinfo?(fyen)
Resolution: --- → FIXED
Unagi pvt v1.0.1 Gaia: 054cdc27404e2daca91d3065d9783681032b2151 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/9c62297d11b0 BuildID 20130828043201 Version 18.0 To http://update.boot2gecko.org/unagi/1.1.0/nightly/update.xml Gaia: 518178ca234c98eb1ca0c0997b9d59faea640a85 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/c3b4683d1360 BuildID 20130828041203 Version 18.0 Verified.
Status: RESOLVED → VERIFIED
Flags: needinfo?(fyen)
v1.1.0hd: 518178ca234c98eb1ca0c0997b9d59faea640a85
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: