907324 - Regression from bug 776446

Status: RESOLVED FIXED

(Firefox Graveyard :: Webapp Runtime, defect)

Description

[Marco Castelluccio [:marco]]

Attachment: remove_bar

After bug 776446 we have a small bar on the bottom of apps' windows. The menu separator in the popupset is causing this.
We could just get rid of it for now and reintroduce it if/when we'll have a context menu with default entries.

Comment 1

[Marco Castelluccio [:marco]]

Attachment: remove_bar

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 793757 [details] [diff] [review]
remove_bar

Review of attachment 793757 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Marco Castelluccio [:marco] from comment #0)
> After bug 776446 we have a small bar on the bottom of apps' windows. The
> menu separator in the popupset is causing this.
> We could just get rid of it for now and reintroduce it if/when we'll have a
> context menu with default entries.

That's ok, although I expect we'll have one soon enough.

In any case, note that the menuseparator should go *inside* the menupopup, so it should be possible to fix this bug by moving it there, although it didn't work in my quick test.

::: webapprt/content/webapp.js
@@ +242,5 @@
>  }
>  
>  nsContextMenu.prototype = {
>    initMenu: function(aXULMenu) {
> +    this.hasPageMenu = PageMenu.maybeBuildAndAttachMenu(document.popupNode, aXULMenu);

Nit: this change makes the line length exceed 80 columns; it should remain wrapped.

Comment 3

[Marco Castelluccio [:marco]]

Attachment: remove_bar

Carrying r+.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/ee2bf84036fb

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Backed out because one of the 4 webapps patches landed on your behalf was causing mochitest-other assertions. You really need to start running your patches through Try before requesting checkin. This is far from the first bustage we've had to backout for.
https://hg.mozilla.org/integration/fx-team/rev/3a3d9846ceca

https://tbpl.mozilla.org/php/getParsedLog.php?id=27007390&tree=Fx-Team

Comment 6

[Marco Castelluccio [:marco]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #5)
> You really need to start running your patches through Try before requesting checkin.

I did: https://tbpl.mozilla.org/?tree=Try&rev=30a4e8eb935c

Maybe it's an intermittent failure.

By the way, this for sure is safe to land.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Definitely not intermittent.
https://tbpl.mozilla.org/?tree=Fx-Team&rev=487e7ea49182

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/796483a1459c

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/796483a1459c