Closed Bug 907337 Opened 11 years ago Closed 11 years ago

Remove the special case for NO_DIST_INSTALL in emitter.py

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla26

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch v2
2.19 KB, patch
mshal
: review+
Details | Diff | Splinter Review
Attached patch Patch v1 (obsolete) — — Splinter Review 
In bug 882859 (attachment 791723 [details] [diff] [review]), I special-cased booleans in recursivemake.py instead.
Attachment #793005 - Flags: review?(mshal)
Attached patch Patch v2 — — Splinter Review 
Good that we have tests.
Attachment #793005 - Attachment is obsolete: true
Attachment #793005 - Flags: review?(mshal)
Attachment #793016 - Flags: review?(mshal)
Comment on attachment 793016 [details] [diff] [review]
Patch v2

Looks good to me!
Attachment #793016 - Flags: review?(mshal) → review+
Depends on: 908142
https://hg.mozilla.org/mozilla-central/rev/40def2576900
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: