Closed Bug 908142 Opened 6 years ago Closed 6 years ago

Move the remainder of FAIL_ON_WARNINGS into moz.build

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla27

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

(Blocks 2 open bugs)

Details

Attachments

(7 files, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #882859 +++
% find . -name 'Makefile.in' | xargs grep FAIL_ON_WARNINGS
./js/xpconnect/shell/Makefile.in:FAIL_ON_WARNINGS := 1
./uriloader/exthandler/tests/Makefile.in:FAIL_ON_WARNINGS = 1
./xpcom/tests/Makefile.in:FAIL_ON_WARNINGS = 1
./security/sandbox/Makefile.in:FAIL_ON_WARNINGS = 1
./security/manager/ssl/tests/unit/test_ocsp_stapling/Makefile.in:FAIL_ON_WARNINGS := 1
./netwerk/test/Makefile.in:FAIL_ON_WARNINGS := 1
I've got patches, but I need to double-check them.
Assignee: nobody → Ms2ger
I grew tired of seeing these variables in the tree.

https://tbpl.mozilla.org/?tree=Try&rev=0e25a6a4bd7e
Attachment #814524 - Flags: review?(Ms2ger)
Assignee: Ms2ger → gps
Comment on attachment 814524 [details] [diff] [review]
Finish moving FAIL_ON_WARNINGS into moz.build

Review of attachment 814524 [details] [diff] [review]:
-----------------------------------------------------------------

So if you have FAIL_ON_WARNINGS in the moz.build and the following in the Makefile:

include $(topsrcdir)/config/config.mk
include $(topsrcdir)/config/rules.mk

then FAIL_ON_WARNINGS is defined in backend.mk which is included in rules.mk, but it needs to be defined by the time config.mk is included. Otherwise the assignment doesn't take effect.
Attachment #814524 - Flags: review?(Ms2ger) → review-
Attachment #814741 - Flags: review?(gps)
Attachment #814742 - Flags: review?(gps)
Attachment #814743 - Flags: review?(gps)
Attachment #814744 - Flags: review?(gps)
Assignee: gps → Ms2ger
Attachment #814524 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #814745 - Flags: review?(gps)
Attachment #814740 - Flags: review?(gps) → review+
Attachment #814741 - Flags: review?(gps) → review+
Attachment #814742 - Flags: review?(gps) → review+
Comment on attachment 814743 [details] [diff] [review]
Part d: js/xpconnect/shell/

Review of attachment 814743 [details] [diff] [review]:
-----------------------------------------------------------------

In what is surely an oversight, DEFINES isn't in FROZEN_VARIABLES. Mucking about with the compile variables after rules.mk inclusion is bad.
Attachment #814743 - Flags: review?(gps) → review-
Attachment #814744 - Flags: review?(gps) → review+
Comment on attachment 814745 [details] [diff] [review]
Part f: Disallow FAIL_ON_WARNINGS in Makefiles

Review of attachment 814745 [details] [diff] [review]:
-----------------------------------------------------------------

I guess I can't review this just yet because of the lingering reference from the r-'d patch.
Attachment #814745 - Flags: review?(gps)
Attachment #815502 - Flags: review?(gps) → review+
Comment on attachment 814745 [details] [diff] [review]
Part f: Disallow FAIL_ON_WARNINGS in Makefiles

Review of attachment 814745 [details] [diff] [review]:
-----------------------------------------------------------------

I guess I can't review this just yet because of the lingering reference from the r-'d patch.
Attachment #814745 - Flags: review+
Attachment #814743 - Flags: review- → review+
https://hg.mozilla.org/mozilla-central/rev/1899772c2f83
https://hg.mozilla.org/mozilla-central/rev/66bb2a099016
https://hg.mozilla.org/mozilla-central/rev/a27418c31cd3
https://hg.mozilla.org/mozilla-central/rev/88e3a46b2c80
https://hg.mozilla.org/mozilla-central/rev/a9b08bb0f5fb
https://hg.mozilla.org/mozilla-central/rev/a8ba29271998

I couldn't actually disallow it in makefiles because js/src is doing something weird. I'll file a followup.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Duplicate of this bug: 916918
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.