907374 - Button API

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: JEP

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 793073 [details]
JEP

><meta http-equiv="refresh" content="5;https://github.com/mozilla/addon-sdk/wiki/JEP-Navbar-Button-2"/>
><a href="https://github.com/mozilla/addon-sdk/wiki/JEP-Navbar-Button-2">
>https://github.com/mozilla/addon-sdk/wiki/JEP-Navbar-Button-2
></a>

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

BTW I have also noticed that there is no way to react to new contexts in which button is created to override state. I think this is unfortunate and specially
relevant in case of location bar buttons where tab can be reloaded many times
and button state is very specific to location. At the moment it seems like one
needs to observe all tabs manually to make sure that state specific to it is
up to date. I think something like `onContext` hook would be ideal to return state
specific to those contexts. For example bookmark button would query bookmarks API
to make button checked or unchecked.

Comment 4

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1214

Pointer to Github pull-request

Comment 5

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 793073 [details]
JEP

><meta http-equiv="refresh" content="5;https://github.com/mozilla/addon-sdk/wiki/JEP-Navbar-Button-2"/>
><a href="https://github.com/mozilla/addon-sdk/wiki/JEP-Navbar-Button-2">
>https://github.com/mozilla/addon-sdk/wiki/JEP-Navbar-Button-2
></a>

Comment 6

[Erik Vold [:erikvold] (please needinfo? me)]

"I don't think it is worth spending any more time arguing on this, Irakli can make the final call.

Comment 7

[Matteo Ferretti [:zer0] [:matteo]]

To me, is still worthy. Sure, we should had this discussion time ago, but we're still in time. If you don't mind about the solution we'll choose, as it seems Erik, I can have a quick 1:1 meeting with Irakli during the work week to define the last details I'm not convinced about – as I wrote in the comment in the JEP, mostly the button with Panel.
Because we're talking about High Level API, I'd like to show such code also to Mossop and Jeff to see what they think – like we did during the previous JEP for the Button, their opinions were really useful if you remember, especially to identify what it looks like easier to the common developers.

Comment 8

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Irakli Gozilalishvili [:irakli] [:gozala] [@gozala] from comment #3)
> BTW I have also noticed that there is no way to react to new contexts in
> which button is created to override state. I think this is unfortunate and
> specially
> relevant in case of location bar buttons where tab can be reloaded many times
> and button state is very specific to location. At the moment it seems like
> one
> needs to observe all tabs manually to make sure that state specific to it is
> up to date. I think something like `onContext` hook would be ideal to return
> state
> specific to those contexts. For example bookmark button would query
> bookmarks API
> to make button checked or unchecked.

This is a very good point.

Comment 9

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 793224 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1214

I just removed myself from the feedback here, because the API was landed. I will update the JEP for Button API in order to merge them; e create a different PR for anchored panels.

Comment 10

[Jeff Griffiths (:canuckistani) (:⚡︎)]

This is all done