907450 - Anchored Panels

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: JEP

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 793180 [details]
JEP

Created combined pull and made request in one place:
https://bug907374.bugzilla.mozilla.org/attachment.cgi?id=793224

Comment 3

[Blake Winton (:bwinton) (:☕️)]

(Just as a side note, I'm waiting for this so that I can convert https://github.com/bwinton/SnoozeTabs over to the new Australis Button API… :)

Comment 4

[Matteo Ferretti [:zer0] [:matteo]]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1398

Comment 5

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 8374981 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1398

Looks, good I would just like to have test case for the example in the pull request description. I don't mind having that test in separate review.

Comment 6

[Matteo Ferretti [:zer0] [:matteo]]

Attachment: test case

I added the test case to the same PR, due the fact is not landed yet. Irakli, could you please take a look?

Comment 7

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 8388496 [details]
test case

Looks fine to me.

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/33173bbc071e3d8c088cd7c6259659da169ae986
Bug 907450 - Anchored Panels …

- Allows `button` and `widget` to be specified as `position` value for panels.
- added `getFocusedBrowser` to window/utils
- use `getFocusedBrowser` in `state` instead of `getMostRecentBrowserWindow`
- Added test case

https://github.com/mozilla/addon-sdk/commit/9f2df5332fb39126ae5917d06ca05c8953449a0d
Merge pull request #1398 from ZER0/anchored-panel/907450

fix Bug 907450 - Anchored Panels r=@gozala