Closed Bug 907816 Opened 7 years ago Closed 7 years ago

domUtils.getCSSValuesForProperty("transform") uses the "display" keyword table

Categories

(Core :: CSS Parsing and Computation, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: Optimizer, Assigned: almasry.mina)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

and thus it returns value slike "inherit", "inline-block" etc.
David, any idea why 'transform' uses this table in nsCSSPropList.h?
Flags: needinfo?(dbaron)
Nope.  Seems like a mistake.  And dates back to https://hg.mozilla.org/mozilla-central/rev/b827e694565d

(Though "inherit" from comment 0 isn't a mistake.)
Flags: needinfo?(dbaron)
That said, I'm also not sure getCSSValuesForProperty should be looking at the property's keyword table unless it has VARIANT_KEYWORD in the variant mask.
Yeah, agreed.

Mina, do you have time for this?
Flags: needinfo?(almasry.mina)
I do have the time for this (which is unfortunate, actually). I should remove the keyword table and check for VARIANT_KEYWORD, correct?
Assignee: nobody → almasry.mina
Flags: needinfo?(almasry.mina) → needinfo?(bzbarsky)
Yep.
Flags: needinfo?(bzbarsky)
Attached patch transform.patchSplinter Review
Here you go.
Attachment #793664 - Flags: review?(bzbarsky)
Comment on attachment 793664 [details] [diff] [review]
transform.patch

r=me
Attachment #793664 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/081011471200
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.