907816 - domUtils.getCSSValuesForProperty("transform") uses the "display" keyword table

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Girish Sharma [:Optimizer]]

and thus it returns value slike "inherit", "inline-block" etc.

Comment 1

[Boris Zbarsky [:bzbarsky]]

David, any idea why 'transform' uses this table in nsCSSPropList.h?

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Nope.  Seems like a mistake.  And dates back to https://hg.mozilla.org/mozilla-central/rev/b827e694565d

(Though "inherit" from comment 0 isn't a mistake.)

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

That said, I'm also not sure getCSSValuesForProperty should be looking at the property's keyword table unless it has VARIANT_KEYWORD in the variant mask.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Yeah, agreed.

Mina, do you have time for this?

Comment 5

[Mina Almasry]

I do have the time for this (which is unfortunate, actually). I should remove the keyword table and check for VARIANT_KEYWORD, correct?

Comment 6

[Boris Zbarsky [:bzbarsky]]

Yep.

Comment 7

[Mina Almasry]

Attachment: transform.patch

Here you go.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 793664 [details] [diff] [review]
transform.patch

r=me

Comment 9

[Mina Almasry]

try push: https://tbpl.mozilla.org/?tree=Try&rev=a3ac461bbf47

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/081011471200

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/081011471200