Closed Bug 907995 Opened 6 years ago Closed 6 years ago

b2g.json cleanup and reorder, part 2

Categories

(Testing :: Mochitest, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla26

People

(Reporter: martijn.martijn, Assigned: martijn.martijn)

Details

Attachments

(1 file, 5 obsolete files)

Attached patch b2g.json.diff (wip) (obsolete) — Splinter Review
Bug 901387 was the first half of categorizing all the exclude list test files and file bugs for every new issue that is seen and removing the test files from the exclude list that are passing.

Bug 868035 will probably land soon, also the xbl test files will be removed from the exclude list soonish, so I want to store this wip patch somewhere for now.
Assignee: nobody → martijn.martijn
Attached patch b2g.json.diff (wip) (obsolete) — Splinter Review
Attachment #793766 - Attachment is obsolete: true
Attached patch b2g.json.diff (wip) (obsolete) — Splinter Review
Attachment #794252 - Attachment is obsolete: true
Attached patch all.diff (obsolete) — Splinter Review
I pushed this (with the fix for bug 908439) to try: https://tbpl.mozilla.org/?tree=Try&rev=14ab6ce4780c
This has a whole bunch of xul/xbl test files removed from the exclude list, because those should be working now, see bug 846090.
Attached patch 907995.diff (obsolete) — Splinter Review
Try server was green, except for bug 908439, which I screwed up, so I put that back in the exclude list. 

I mainly added comments to the exclude list to bug numbers.
And like I said, I removed the now working xbl/xul tests from the exclude list.

I retriggered the try server 15 times for the relevant chunks (for the tests files that were added) to look out for intermittent failures.
Attachment #795104 - Attachment is obsolete: true
Attachment #795149 - Attachment is obsolete: true
Attachment #795173 - Flags: review?(jmaher)
Chunk 9 failed once out of 15 times, but that is bug 906793, a known intermittent failure. The rest all green.
Comment on attachment 795173 [details] [diff] [review]
907995.diff

Review of attachment 795173 [details] [diff] [review]:
-----------------------------------------------------------------

lots of great cleanup!

::: testing/mochitest/android.json
@@ +110,5 @@
>   "docshell/test/navigation/test_bug430723.html": "TIMED_OUT",
>   "docshell/test/navigation/test_popup-navigates-children.html": "bug 783589",
>   "docshell/test/navigation/test_sessionhistory.html": "RANDOM",
>   "docshell/test/navigation/test_bug344861.html": "",
> + "docshell/test/test_bug94514.html": "moved to toolkit, can be removed",

can we just remove this?

::: testing/mochitest/androidx86.json
@@ +114,5 @@
>   "docshell/test/navigation/test_not-opener.html": "x86 only",
>   "docshell/test/navigation/test_popup-navigates-children.html": "bug 783589",
>   "docshell/test/navigation/test_sessionhistory.html": "RANDOM",
>   "docshell/test/navigation/test_bug344861.html": "",
> + "docshell/test/test_bug94514.html": "moved to toolkit, can be removed",

can we just remove this?

::: testing/mochitest/b2g.json
@@ +116,5 @@
>      "dom/tests/mochitest/ajax/offline/test_lowDeviceStorage.html":"",
>      "dom/tests/mochitest/ajax/offline/test_lowDeviceStorageDuringUpdate.html":"",
>      "dom/tests/mochitest/ajax/offline/test_missingFile.html":"",
>      "dom/tests/mochitest/ajax/offline/test_missingManifest.html":"",
> +    "dom/tests/mochitest/ajax/offline/test_noManifest.html":"",

is there a bug for this?  a comment?
Attachment #795173 - Flags: review?(jmaher) → review+
(In reply to Joel Maher (:jmaher) from comment #6)
> can we just remove this?

You're right, I'll remove those.
 
> > +    "dom/tests/mochitest/ajax/offline/test_noManifest.html":"",
> 
> is there a bug for this?  a comment?

Nothing changed, I just moved that line to a more appropriate spot (with the rest of the offline tests). I somehow managed to put test_bug629535.html in there too, that doesn't make sense, but that line should be removed pretty soon, anyhow, when bug 908439 gets fixed.
Attachment #795173 - Attachment is obsolete: true
Keywords: checkin-needed
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6238f22b7fec
Status: NEW → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.