908057 - [B2G][Helix][everthing search][yangshiqi]The thumbnails and text of the app in everthing search are overlapping and imperfect

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect, P2)

Description

[lecky]

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)

Steps to reproduce:

The thumbnails and text of the app in everthing search are overlapping and imperfect
1.Press everthing search to enter in ,
2.check the app thumbnails and text in it
3.press any thumbnails of the app to enter in
4.check the app thumbnails and text in it



Actual results:

The thumbnails and text of the app in everthing search are overlapping and imperfect


Expected results:

The thumbnails and text of the app display normally

Comment 1

[Wayne Chang [:wchang]]

Hi Ran,

I think this is already under your radar?

Aiming for v1.2 here.

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Hey Wayne, I was told that v1.1.0hd should no longer need attention.
This bug does not appear in master afaik.

So, is it still relevant?

Comment 3

[lecky]

Would that be acceptable if this bug is not fixed in v1.1.

Comment 4

[Beatriz Rodríguez [:brg]]

Can you attach several screenshots of the issue?  To make an screenshot you must press home and power on key at the same time. Thanks.

Comment 5

[lecky]

Attachment: 2013-09-25-13-56-54.png

Comment 6

[lecky]

Attachment: 2013-09-25-13-57-25.png

Comment 7

[lecky]

Attachment: 2013-09-25-13-58-13.png

Comment 8

[lecky]

Attachment: 2013-09-25-13-58-28.png

Comment 9

[Ran Ben Aharon [:ranbena] EverythingMe]

This issue was fixed in master in Bug 910338

Comment 10

[lecky]

hi ,I aleady privoid some screenshots,and still wait you reply ,do you have a result

Comment 11

[Beatriz Rodríguez [:brg]]

(In reply to Ran Ben Aharon (Everything.me) from comment #9)
> This issue was fixed in master in Bug 910338
This is a bug for branch 1.1hd. We need a patch for this specific branch. I do not know if it is better to include your patch here or ask for hd+ in your current implementation for master(the bug you pointed 910338 had no patches included, there must be a mistake. What is the best way to proceed?

Comment 12

[Ran Ben Aharon [:ranbena] EverythingMe]

We aim to attach a patch by Oct 22nd.

Comment 13

[Beatriz Rodríguez [:brg]]

Thanks Ran, nominating to hd accordingly

Comment 14

[Wayne Chang [:wchang]]

Hi Ran,

Sorry I missed your comment on this til now. v1.1HD was resurrected and we need to have this corrected.
Would bug 905455 not fix this here?

Thanks.

Comment 15

[Evyatar 'Tron' Amitay (everything.me)]

hi Wayne - unfortunately bug 905455 only handles master, which is at this point too far from 1.1.
I'm now preparing a patch specifically for 1.1.

Comment 16

[Evyatar 'Tron' Amitay (everything.me)]

Attachment: Patch - redirect to github PR

Pretty small fixes. the issue was that we once used Canvas in the HTML. And we set the canvas' CSS width/height according to the device pixel ratio. BUT since then we moved on to use IMG tags instead of Canvas, and we left the width/height CSS on the canvas.

tl;dr - I put CSS width/height on the displayed images with the real size.

Comment 17

[Ran Ben Aharon [:ranbena] EverythingMe]

Comment on attachment 819443 [details]
Patch - redirect to github PR

Works great

Comment 18

[Evyatar 'Tron' Amitay (everything.me)]

merged to v1.1.0hd
1b11c1e926d236b374f07a6ad7eddab89de228ce

https://github.com/mozilla-b2g/gaia/commit/1b11c1e926d236b374f07a6ad7eddab89de228ce

Comment 19

[Ran Ben Aharon [:ranbena] EverythingMe]

Beatriz, we'd like to uplift this to v1.2 as well. Should we change the nom to koi?

Comment 20

[Beatriz Rodríguez [:brg]]

Please uplift this fix in v1.2 as well.

Comment 21

[Evyatar 'Tron' Amitay (everything.me)]

uplifted to 1.2
00d5964eabf95a6a8a632420dfa36fc76dcbc9b7

https://github.com/mozilla-b2g/gaia/commit/00d5964eabf95a6a8a632420dfa36fc76dcbc9b7

* Please note I had to add this change as well, since v1.2 is very different than v1.1 https://github.com/mozilla-b2g/gaia/commit/00d5964eabf95a6a8a632420dfa36fc76dcbc9b7#diff-0

Comment 22

[Jason Smith [:jsmith]]

Note - for verifications, use verifyme if you need QA verification, not qawanted.

Comment 23

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Update v1.1 flag based on comment 21.

v1.1.0hd: 48d6065eaaad98edaa639a7c2dadf3a7e464e481
v1.1.0hd: 1b11c1e926d236b374f07a6ad7eddab89de228ce

Comment 24

[lecky]

Attachment: white blank.rar

Comment 25

[lecky]

Attachment: 20131011055921baobo-进入设置显示白屏.7z

Comment 26

[lecky]

Please ignore "Comment 24" and  "Comment 25", i miss-uploaded the log, they are for another bugreport.

Sorry for this.

Thanks!

Comment 27

[William Hsu [:whsu]]

Verified it.

* Test Build: (Mozilla Build)
 - Gaia:     63cd1d96b5a94e9b22ffc54dfde48ef6d3cf996b
 - Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/7cd7f30328e1
 - BuildID   20131022042302
 - Version   18.0

Attaching the screenshot.

Comment 28

[William Hsu [:whsu]]

Attachment: [E.ME] Main page