908207 - [Contacts] Name is not displayed in contact details if last name is not provided

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Salvador de la Puente González [:salva]]

STR:

1- Open Contacts
2- Add a new contact. Provide ONLY name.
3- Save the contact. Ignore any attempt to merge with another contact.
4- Look for the contact added in step 2.
5- See contact details.

Expected:
Name is shown in the header of the screen.

Actual:
The header is empty.

Comment 1

[Salvador de la Puente González [:salva]]

Once bug 906756 is landed, this will be fixed.

Comment 2

[Salvador de la Puente González [:salva]]

Bux 906756 landed. I've checked the STR. It is not reproducing.

Comment 3

[Borja Salguero [:borjasalguero]]

When calling contact activity from other apps (for example SMS), after saving a contact with name 'Robert' and phone number '123':

EXPECTED:
{"name":"Robert","number":"123","type":"","carrier":"","separator":"","nameHTML":"","numberHTML":""}

CURRENTLY:
{"name":"123","number":"123","type":"","carrier":"","separator":"","nameHTML":"","numberHTML":""}

Reopening

Comment 4

[Borja Salguero [:borjasalguero]]

Im going to investigate this because is blocking some SMS/MMS work. Taking this!

Comment 5

[Borja Salguero [:borjasalguero]]

After debugging it's issue is tied to SMS. With new activity made by Fernando, this seems not reproducible anymore. Moving all work to the bug related with SMS.

Comment 6

[Salvador de la Puente González [:salva]]

As bug 906756 has been reopen this bug has reappeared.

Comment 7

[Salvador de la Puente González [:salva]]

Attachment: Fix name creation taking noting givenName and familyName are arrays.

Comment 8

[Jose Manuel Cantera]

Comment on attachment 800192 [details]
Fix name creation taking noting givenName and familyName are arrays.

thanks Salva, for fixing this.

Comment 9

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/81c56b165dceb823838c8641a83db1d4adb34437

Comment 10

[isabelrios]

Verified on v1.2 11/18 build:
Gecko-1443247
Gaia-7a23f8c