Closed Bug 906756 Opened 6 years ago Closed 6 years ago

[Contacts] Change algorithm to merge "given name" and "last name" fields to preserve master values

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

x86_64
Linux
defect
Not set

Tracking

(blocking-b2g:koi+)

RESOLVED FIXED
blocking-b2g koi+

People

(Reporter: salva, Assigned: salva)

References

Details

(Whiteboard: [u=commsapps-user c=contacts p=7])

Attachments

(1 file, 1 obsolete file)

At the same time, the fields coming from suggestions are not lost but stored in the extra positions (second, third, fourth...) of the givenName / lastName arrays:

https://wiki.mozilla.org/WebAPI/ContactsAPI#API
blocking-b2g: --- → koi?
Whiteboard: [u=commsapps-user c=contacts p=0]
New tests added.
Adapt and merge changed to allow specifying the master contact.
Name composition centralized to avoid code repetition.
Some libraries updated.
Attachment #796147 - Flags: review?(francisco.jordano)
Whiteboard: [u=commsapps-user c=contacts p=0] → [u=commsapps-user c=contacts p=7]
Comment on attachment 796147 [details]
Algorithms for merging givenName and familyName changed.

Hi,

seems we have some corner cases that are making the merge functionality fail. Please take a look to the comments in github.

Anyway, the work is looking pretty good :), sure solving those problems will be easy for you!

Thanks a lot Salva!
Attachment #796147 - Flags: review?(francisco.jordano) → review-
koi+ as this is part of the contacts merge stories
please add dependencies to the bug as well. Thanks
blocking-b2g: koi? → koi+
Comment on attachment 796147 [details]
Algorithms for merging givenName and familyName changed.

Comments fixed. Can you review the code again, please?
Thank you.
Attachment #796147 - Flags: review- → review?(francisco.jordano)
Comment on attachment 796147 [details]
Algorithms for merging givenName and familyName changed.

\o/

Working pretty nice, thanks Salva!
Attachment #796147 - Flags: review?(francisco.jordano) → review+
Master: af587d3201332a8fb0c96e5aa4c771031796a5f7
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
This bug has been backed out. Due to unneeded changes it has regressed import UI functionalities as reported by bug 912100
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached file 11921.html
Pointer to GH PR 11921
Attachment #796147 - Attachment is obsolete: true
Attachment #799359 - Flags: review?(salva)
Comment on attachment 799359 [details]
11921.html

Just a little comment on GitHub, not blocking but desirable.

Thank you for your feedback. You're right. The former bug was very intrusive.
Attachment #799359 - Flags: review?(salva) → review+
Comment on attachment 799359 [details]
11921.html

I detected and error and I don't know why are the tests passing. See on GitHub.
Attachment #799359 - Flags: review+ → review-
fixed
Attachment #799359 - Flags: review- → review?(salva)
Comment on attachment 799359 [details]
11921.html

Only a little comment more. Not blocking.

Thank you very much :)
Attachment #799359 - Flags: review?(salva) → review+
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.