Closed
Bug 909003
Opened 11 years ago
Closed 11 years ago
Cleanup BindingUtils.h includes
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
(Blocks 2 open bugs)
Details
Attachments
(7 files)
|
914 bytes,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
2.00 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
2.45 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
3.88 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
2.29 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
2.22 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
2.10 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #795033 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #795034 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #795035 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #795036 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Comment on attachment 795036 [details] [diff] [review] Part d: Remove some includes in nsHistory.h Not going to get rid of cleanups. Includes, otoh...
Attachment #795036 -
Attachment description: Part d: Remove some cleanups in nsHistory.h → Part d: Remove some includes in nsHistory.h
|
|
Assignee | |
Comment 6•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #795037 -
Attachment description: webspeech-bu → Part e: Remove some includes from SpeechGrammarList.h
Attachment #795037 -
Attachment is patch: true
Attachment #795037 -
Attachment mime type: message/rfc822 → text/plain
Attachment #795037 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 7•11 years ago
|
||
Attachment #795038 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 8•11 years ago
|
||
Attachment #795039 -
Flags: review?(bzbarsky)
|
||
Comment 9•11 years ago
|
||
Comment on attachment 795033 [details] [diff] [review] Part a: Add missing includes to TypedArray.h r=me
Attachment #795033 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 10•11 years ago
|
||
Comment on attachment 795034 [details] [diff] [review] Part b: Sort includes in WebSocket.h r=me
Attachment #795034 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 11•11 years ago
|
||
Comment on attachment 795035 [details] [diff] [review] Part c: Remove some includes from WebSocket.h r=me
Attachment #795035 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 12•11 years ago
|
||
Comment on attachment 795036 [details] [diff] [review] Part d: Remove some includes in nsHistory.h r=me
Attachment #795036 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 13•11 years ago
|
||
Comment on attachment 795037 [details] [diff] [review] Part e: Remove some includes from SpeechGrammarList.h r=me However, maybe we should have a BindingForwardDeclarations.h or something that will do things like forward-declare Optional?
Attachment #795037 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 14•11 years ago
|
||
Comment on attachment 795038 [details] [diff] [review] Part f: Remove some includes from IDBFactory.h r=me
Attachment #795038 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 15•11 years ago
|
||
Comment on attachment 795039 [details] [diff] [review] Part g: Remove some includes in workers r=me
Attachment #795039 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 16•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e5469d8c3a56 https://hg.mozilla.org/mozilla-central/rev/4811bd5aea43 https://hg.mozilla.org/mozilla-central/rev/10055975c7c4 https://hg.mozilla.org/mozilla-central/rev/ab4e4e5c501a https://hg.mozilla.org/mozilla-central/rev/c60685a09dd2 https://hg.mozilla.org/mozilla-central/rev/528bc7fbebb5 https://hg.mozilla.org/mozilla-central/rev/ab5f29823236
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•