Cleanup BindingUtils.h includes

RESOLVED FIXED in mozilla26

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

(Blocks: 2 bugs)

Trunk
mozilla26
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(7 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 795033 [details] [diff] [review]
Part a: Add missing includes to TypedArray.h
Attachment #795033 - Flags: review?(bzbarsky)
(Assignee)

Comment 2

5 years ago
Created attachment 795034 [details] [diff] [review]
Part b: Sort includes in WebSocket.h
Attachment #795034 - Flags: review?(bzbarsky)
(Assignee)

Comment 3

5 years ago
Created attachment 795035 [details] [diff] [review]
Part c: Remove some includes from WebSocket.h
Attachment #795035 - Flags: review?(bzbarsky)
(Assignee)

Comment 4

5 years ago
Created attachment 795036 [details] [diff] [review]
Part d: Remove some includes in nsHistory.h
Attachment #795036 - Flags: review?(bzbarsky)
(Assignee)

Comment 5

5 years ago
Comment on attachment 795036 [details] [diff] [review]
Part d: Remove some includes in nsHistory.h

Not going to get rid of cleanups. Includes, otoh...
Attachment #795036 - Attachment description: Part d: Remove some cleanups in nsHistory.h → Part d: Remove some includes in nsHistory.h
(Assignee)

Comment 6

5 years ago
Created attachment 795037 [details] [diff] [review]
Part e: Remove some includes from SpeechGrammarList.h
(Assignee)

Updated

5 years ago
Attachment #795037 - Attachment description: webspeech-bu → Part e: Remove some includes from SpeechGrammarList.h
Attachment #795037 - Attachment is patch: true
Attachment #795037 - Attachment mime type: message/rfc822 → text/plain
Attachment #795037 - Flags: review?(bzbarsky)
(Assignee)

Comment 7

5 years ago
Created attachment 795038 [details] [diff] [review]
Part f: Remove some includes from IDBFactory.h
Attachment #795038 - Flags: review?(bzbarsky)
(Assignee)

Comment 8

5 years ago
Created attachment 795039 [details] [diff] [review]
Part g: Remove some includes in workers
Attachment #795039 - Flags: review?(bzbarsky)
Comment on attachment 795033 [details] [diff] [review]
Part a: Add missing includes to TypedArray.h

r=me
Attachment #795033 - Flags: review?(bzbarsky) → review+
Comment on attachment 795034 [details] [diff] [review]
Part b: Sort includes in WebSocket.h

r=me
Attachment #795034 - Flags: review?(bzbarsky) → review+
Comment on attachment 795035 [details] [diff] [review]
Part c: Remove some includes from WebSocket.h

r=me
Attachment #795035 - Flags: review?(bzbarsky) → review+
Comment on attachment 795036 [details] [diff] [review]
Part d: Remove some includes in nsHistory.h

r=me
Attachment #795036 - Flags: review?(bzbarsky) → review+
Comment on attachment 795037 [details] [diff] [review]
Part e: Remove some includes from SpeechGrammarList.h

r=me

However, maybe we should have a BindingForwardDeclarations.h or something that will do things like forward-declare Optional?
Attachment #795037 - Flags: review?(bzbarsky) → review+
Comment on attachment 795038 [details] [diff] [review]
Part f: Remove some includes from IDBFactory.h

r=me
Attachment #795038 - Flags: review?(bzbarsky) → review+
Comment on attachment 795039 [details] [diff] [review]
Part g: Remove some includes in workers

r=me
Attachment #795039 - Flags: review?(bzbarsky) → review+
You need to log in before you can comment on or make changes to this bug.