909204 - Display Composition FPS while using HwcComposer2D

Status: RESOLVED INVALID

(Core :: Graphics, defect)

Description

[u459114]

FPS sprite display only when GLComposer be chosen.

Comment 1

[u459114]

Let me take this issue

Comment 2

[Jerry Shih[:jerry] (UTC+8) (inactive)]

reference code for fps rendering
http://mxr.mozilla.org/mozilla-central/source/gfx/layers/opengl/CompositorOGL.cpp#108

Comment 3

[u459114]

I think we should display the following information on the screen for all compositor back-end with minimum performance impact
1. FPS
2. Composed Layer number
3. Optional - CPU usage

Comment 4

[u459114]

Here is my proposal of generate FPS sprite:
1. (FPS bitmap) Generate bitmap for each FPS. For exp, "FPS: 20" and "FPS: 21" will be two disinct bitmap. Keep these image in memory persistly. As a result, generate these bitmap is one-time event.
2. (FPS bitmap map) Use hash value of each bitmap(Hash("FPS:20")) as index to find out existed FPS bitmap. 
3. Always render FPS bitmap on the deepest layer(backgound layer).

Comment 5

[u459114]

Attachment: WIP_Draw_FPS_in_HWC

1. Just a work flow draft.
2. HwcComposer2D::DrawFPS is the entry point of FPS drawing
   a. Find a suitable layer.
   b. draw FPS image direct into the content of that layer.

Comment 6

[u459114]

Next step
1. Render "0-9" stretch into a graphic buffer by opengl: do it in FPSCounter
2. Map number glyph into layer image according to current FPS.

Comment 7

[u459114]

Attachment: WIP_Draw_FPS_in_HWC

Comment 8

[u459114]

Attachment: WIP_Draw_FPS_in_HWC

Comment 9

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Bug 915342 shows the fill ratio for GL composition.

We can also show the number of composed layer.
It might be helpful to check unnecessary layer.

Comment 10

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Is there any way we can integrate this with bug 874781?  I know I keep saying I'm going to get back to and finish that up; I will try doing so tomorrow or Monday.

Comment 11

[u459114]

Attachment: WIP_Draw_FPS_in_HWC

WIP

Comment 12

[u459114]

(In reply to Vladimir Vukicevic [:vlad] [:vladv] from comment #10)
> Is there any way we can integrate this with bug 874781?  I know I keep
> saying I'm going to get back to and finish that up; I will try doing so
> tomorrow or Monday.
Sure. Basically, I will finish the logic of drawing FPS in HWC. 
I didn't use GL to draw FPS in HWC, instead, I blit FPS image into a suitable layer directly.
The reason for this approach is
1. Needless to add another FPS layer: adding a layer in generic HWC is not good.
2. Decouple with GLComposer

Make this bug depend on 874781

Comment 13

[u459114]

Attachment: WIP_Draw_FPS_in_HWC

Validate the size of drawing layer.

Comment 14

[u459114]

Attachment: WIP_Draw_FPS_in_HWC

Comment 15

[u459114]

Peter/ Morris, any suggestion?

Comment 16

[u459114]

TODO:
1. Rework base on bug 874781
2. Comment
3. Layer selection algorithm
   Currently, I search from back to front, get the first suitable layer, and then draw image onto left-top side of that layer. Simple/effective, but may not work if that layer is cover by another layer, FPS sprite will not be visible.

Comment 17

[u459114]

Attachment: WIP_Draw_FPS_in_HWC

Update layer selection algorithm

Comment 18

[u459114]

TODO
1. Draw FPS in hwcLayer.sourceCrop boundary
2. Enable FPS drawing from LayerManager.

Comment 19

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Check the preferences "layers.acceleration.draw-fps" to trigger this function?

Comment 20

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: Read pref from fifo

Read preference setting from device /data/locat/tmp/gfx_debug

Check CompositorDebugPropWatcher::OnFileCanReadWithoutBlocking() function

Comment 21

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.

Comment 22

[Gregory Pappas [:gregp]]

Closing old B2G bugs