909211 - Clean up the promise usage in Scratchpad

Status: RESOLVED INVALID

(DevTools Graveyard :: Scratchpad, defect, P3)

Description

[Brandon Benvie [:benvie]]

The use of promises in the Scratchpad can be cleaned up quite a bit.

Comment 1

[Brandon Benvie [:benvie]]

Attachment: WIP1

This is an initial stab at it. The main thrust is that it wraps ObjectClient callbacks in promise returning functions. The trick with how the Scratchpad works is that ordering the promises correctly while still returning the [code, error, result] tuple. So it's like:

* execute code -> results
* do intermediate stuff that uses promises
* resolve will results

So it turns out to be a slightly bit hacky to do this, but it's still cleaner than the existing implementation.

Comment 2

[Brandon Benvie [:benvie]]

Nick suggested to me that it would be better to complete bug 906202 (promisify the debugger client) before doing this. It would make the wrapping of ObjectClient methods I'm doing unnecessary.

Comment 3

[Brandon Benvie [:benvie]]

Unassigning for now until bug 910141 lands (which isn't actively being worked on yet).

Comment 4

[Sebastian Zartner [:sebo]]

Bulk changing the status, as there is no assignee anymore.

Sebastian

Comment 5

[Patrick Brosset <:pbro>]

Old refactoring bug that we have not touched in the past 4 years. Additionally, there are no instances of promise.defer in scratchpad anymore. So, closing.