Closed
Bug 909263
Opened 8 years ago
Closed 8 years ago
Undefined reference to nsMemory in external API builds
Categories
(MailNews Core :: LDAP Integration, defect)
MailNews Core
LDAP Integration
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 26.0
People
(Reporter: neil, Assigned: neil)
Details
(Whiteboard: [external-api-bustage])
Attachments
(1 file, 1 obsolete file)
3.42 KB,
patch
|
jcranmer
:
review+
mkmelin
:
feedback+
|
Details | Diff | Splinter Review |
Presumably due to some include-what-you-use changes, ldap/xpcom/src no longer compiles against the external API.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #795371 -
Flags: review?
Assignee | ||
Updated•8 years ago
|
Attachment #795371 -
Flags: review?(Pidgeot18)
Attachment #795371 -
Flags: review?
Attachment #795371 -
Flags: feedback?(mkmelin+mozilla)
Assignee | ||
Comment 2•8 years ago
|
||
Note that this just gets my external build past LDAP; it's failing in nsMessengerUnixIntegration.cpp now.
Whiteboard: [external-api-bustage]
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to comment #2) > it's failing in nsMessengerUnixIntegration.cpp now. Ah, that's bug 903283.
Assignee | ||
Comment 4•8 years ago
|
||
Turns out there was one other include of nsMemory needed.
Assignee: nobody → neil
Attachment #795371 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #795371 -
Flags: review?(Pidgeot18)
Attachment #795371 -
Flags: feedback?(mkmelin+mozilla)
Attachment #795376 -
Flags: review?(Pidgeot18)
Attachment #795376 -
Flags: feedback?(mkmelin+mozilla)
Comment 5•8 years ago
|
||
Comment on attachment 795376 [details] [diff] [review] Proposed patch Review of attachment 795376 [details] [diff] [review]: ----------------------------------------------------------------- ::: ldap/xpcom/src/nsLDAPConnection.cpp @@ +222,5 @@ > NS_IMETHODIMP > nsLDAPConnection::Observe(nsISupports *aSubject, const char *aTopic, > const PRUnichar *aData) > { > + if (!strcmp(aTopic, "profile-change-net-teardown")) { Death to nsCRT! :-)
Attachment #795376 -
Flags: review?(Pidgeot18) → review+
Comment 6•8 years ago
|
||
Comment on attachment 795376 [details] [diff] [review] Proposed patch Builds for me!
Attachment #795376 -
Flags: feedback?(mkmelin+mozilla) → feedback+
Comment 7•8 years ago
|
||
Neil: Forgot to check this in?
Assignee | ||
Comment 8•8 years ago
|
||
No, just that the tree was burning last time I looked at it.
Assignee | ||
Comment 9•8 years ago
|
||
Pushed comm-central changeset 8b62535822f1.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 26.0
You need to log in
before you can comment on or make changes to this bug.
Description
•