Closed Bug 909263 Opened 7 years ago Closed 7 years ago

Undefined reference to nsMemory in external API builds

Categories

(MailNews Core :: LDAP Integration, defect)

Product:
MailNews Core
Component:
LDAP Integration
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 26.0

People

(Reporter: neil, Assigned: neil)

Details

(Whiteboard: [external-api-bustage])

Attachments

(1 file, 1 obsolete file)

Proposed patch
3.42 KB, patch
jcranmer
: review+
mkmelin
: feedback+
Details | Diff | Splinter Review 
Presumably due to some include-what-you-use changes, ldap/xpcom/src no longer compiles against the external API.
Attached patch Proposed patch (obsolete) — — Splinter Review
Attachment #795371 - Flags: review?
Attachment #795371 - Flags: review?(Pidgeot18)
Attachment #795371 - Flags: review?
Attachment #795371 - Flags: feedback?(mkmelin+mozilla)
Note that this just gets my external build past LDAP; it's failing in nsMessengerUnixIntegration.cpp now.
Whiteboard: [external-api-bustage]
(In reply to comment #2)
> it's failing in nsMessengerUnixIntegration.cpp now.

Ah, that's bug 903283.
Attached patch Proposed patch — — Splinter Review 
Turns out there was one other include of nsMemory needed.
Assignee: nobody → neil
Attachment #795371 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #795371 - Flags: review?(Pidgeot18)
Attachment #795371 - Flags: feedback?(mkmelin+mozilla)
Attachment #795376 - Flags: review?(Pidgeot18)
Attachment #795376 - Flags: feedback?(mkmelin+mozilla)
Comment on attachment 795376 [details] [diff] [review]
Proposed patch

Review of attachment 795376 [details] [diff] [review]:
-----------------------------------------------------------------

::: ldap/xpcom/src/nsLDAPConnection.cpp
@@ +222,5 @@
>  NS_IMETHODIMP
>  nsLDAPConnection::Observe(nsISupports *aSubject, const char *aTopic,
>                            const PRUnichar *aData)
>  {
> +  if (!strcmp(aTopic, "profile-change-net-teardown")) {

Death to nsCRT! :-)
Attachment #795376 - Flags: review?(Pidgeot18) → review+
Comment on attachment 795376 [details] [diff] [review]
Proposed patch

Builds for me!
Attachment #795376 - Flags: feedback?(mkmelin+mozilla) → feedback+
Neil: Forgot to check this in?
No, just that the tree was burning last time I looked at it.
Pushed comm-central changeset 8b62535822f1.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 26.0
You need to log in before you can comment on or make changes to this bug.