909263 - Undefined reference to nsMemory in external API builds

Status: RESOLVED FIXED

(MailNews Core :: LDAP Integration, defect)

Description

[[e-mail]]

Presumably due to some include-what-you-use changes, ldap/xpcom/src no longer compiles against the external API.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[[e-mail]]

Note that this just gets my external build past LDAP; it's failing in nsMessengerUnixIntegration.cpp now.

Comment 3

[[e-mail]]

(In reply to comment #2)
> it's failing in nsMessengerUnixIntegration.cpp now.

Ah, that's bug 903283.

Comment 4

[[e-mail]]

Attachment: Proposed patch

Turns out there was one other include of nsMemory needed.

Comment 5

[Joshua Cranmer [:jcranmer]]

Comment on attachment 795376 [details] [diff] [review]
Proposed patch

Review of attachment 795376 [details] [diff] [review]:
-----------------------------------------------------------------

::: ldap/xpcom/src/nsLDAPConnection.cpp
@@ +222,5 @@
>  NS_IMETHODIMP
>  nsLDAPConnection::Observe(nsISupports *aSubject, const char *aTopic,
>                            const PRUnichar *aData)
>  {
> +  if (!strcmp(aTopic, "profile-change-net-teardown")) {

Death to nsCRT! :-)

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 795376 [details] [diff] [review]
Proposed patch

Builds for me!

Comment 7

[Magnus Melin [:mkmelin]]

Neil: Forgot to check this in?

Comment 8

[[e-mail]]

No, just that the tree was burning last time I looked at it.

Comment 9

[[e-mail]]

Pushed comm-central changeset 8b62535822f1.