909266 - [wasabi] Roaming preference setting will not be saved if reboot DUT right after change the setting.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Enpei]

Attachment: before reboot logcat.

Roaming preference setting cannot be saved after reboot. It will be restored back to "Any".

* Build Number                
Gaia:     f94d4a9b56e8cc253089fe5ff680eb3cde303243
  B-D     2013-08-26 02:13:16
Gecko:   f216c745e68da490fd5591991398092d56d35294
BuildID   20130826061633
Version   26.0a1

* Reproduce Steps
1. Set Roaming preference to any item other than "Any".
2. Reboot device.

* Expected Result
New roaming preference setting should be saved even reboot device. 

* Actual Result
Back to "Any"

* Occurrence rate
100%

Comment 1

[Enpei]

Attachment: after reboot device logcat.

Comment 2

[Ivan Tsay (:ITsay)]

Need to fix it in v1.2

Comment 3

[Enpei]

Update title, it's the same as bug 913326 that setting is not saved if reboot right after udpating the setting.

Comment 4

[Ivan Tsay (:ITsay)]

Move to v1.3 since no requirement for CDMA in v1.2

Comment 5

[Francis Lee [:frlee]]

according to triage result, changed to 1.3+

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

This is similar to bug 913326. Does gecko keep the setting?

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

No, gecko doesn't...

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/14957

As we stop using mozSettings to control the hardware and gecko does not store the hardware states after restart, we need to store the user preferences in mozSettings and call gecko API accordingly when restart. For example, voice privacy in bug 913326, roaming preference in the bug, preferred network types...etc. Instead of having a helper for each API, I would like to introduce a more generic helper in the patch.

The behavior of the helper is the same as the one created in bug 913326 (VoicePrivacySettingsHelper) bug with more generic methods. Could you help provide some feedback? Thanks.

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8351357 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/14957

f+ but see github

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8351357 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/14957

Alive, Jose, could you help review the patch? Thanks!

As comment 8, I added a generic SettingsHelper and replaced the original VoicePrivacySettingsHelper with it. The logic of SettingsHelper is almost the same VoicePrivacySettingsHelper but with more general APIs.

Comment 11

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8351357 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/14957

(In reply to Arthur Chen [:arthurcc] from comment #10)
> Comment on attachment 8351357 [details]
> Link to https://github.com/mozilla-b2g/gaia/pull/14957
> 
> Alive, Jose, could you help review the patch? Thanks!

Sure, but I'd like to remark that I don't have a CDMA to test the patch.
 
> As comment 8, I added a generic SettingsHelper and replaced the original
> VoicePrivacySettingsHelper with it. The logic of SettingsHelper is almost
> the same VoicePrivacySettingsHelper but with more general APIs.

LGTM, thanks for the work. Left some comments, check them out please.

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8351357 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/14957

See github nits

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks for reviewing!

master: 3b603d6adb6b92df347f953e22e4c5f35927c97d

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1.3.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.3, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.3
  git cherry-pick -x -m1 3b603d6adb6b92df347f953e22e4c5f35927c97d
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 15

[Arthur Chen [:arthurcc][inactive after 6/30]]

v1.3: 2df82d7715cd44d2b6a580e6b7854b3017d4c6a9

Comment 16

[Enpei]

Verified on Wasabi

Gaia      7fc5eb67ff0aedbeb6874f670891e8e9b4505a16
Gecko     2b1732ba02eb74ec81f54f19cd9ef81da6c12844
BuildID   20140116100919
Version   28.0a2