909280 - Keycodes not available for Umlauts

Status: RESOLVED INVALID

(Core :: DOM: Events, defect)

Description

[Martin]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/29.0.1547.57 Safari/537.36

Steps to reproduce:

There is no KeyCode for Umlauts on keydown:

http://unixpapa.com/js/testkey.html  

e.g: Hit  "ä" on the keyboard on this testsite

keydown  keyCode=0         which=0         charCode=0        
keypress keyCode=0         which=228       charCode=228      
keyup    keyCode=0         which=0         charCode=0        


Actual results:

No KeyCode was delivered in Firefox:

keyCode=0 instead of keyCode=222 on keydown event


Expected results:

The appropriate Keycode should be set on keydown, keypress, keydown

e.g (other browsers)
keydown  keyCode=222       which=222       charCode=0        
keypress keyCode=228       which=228       charCode=228      
keyup    keyCode=222       which=222       charCode=0

Comment 2

[u279076]

From bug 1176666 it seems like this would be a good-first-bug for someone to mentor.

Comment 3

[John Daggett (:jtd)]

Anthony, can you provide a bit more context to your needinfo requests? What did you want me to do here?

I'm guessing this is less about text display than it is about keyboard handling. Guessing Nakano-san might be a good person to loop in.

Comment 4

[u279076]

Hi John, sorry I wasn't clear. I thought this would be a good "feature" for a contributor to work on and was thinking you might know someone who could be a mentor for said hypothetical contributor.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

It depends on what the key inputs with other modifier states. See *our* keyCode computation spec:
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode#Printable_keys_in_standard_position

Fortunately, we've already implemented KeyboardEvent.key. Web apps should refer it (or KeyboardEvent.code if you need to know which *physical* key is pressed).

I close this bug as INVA, but if current behavior is different from the *our* spec mentioned above, feel free to reopen this bug.

Comment 6

[u223795]

Hi,

the issue still exists. Please reopen the bug.

Best,

Johannes

Comment 7

[u279076]

(In reply to Johannes Eckhardt from comment #6)
> Hi,
> 
> the issue still exists. Please reopen the bug.

I think the issue is not whether the bug exists, it's whether the case you refer to is adhering to the spec (see comment 5). If it is adhering to the spec and the characters still don't display properly then it's probably our bug. If it's not adhering to the spec then the bug is not in our code.