909511 - ""toString" is read-only" in errors in osfile_unix_allthreads.jsm

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, defect)

Description

[[:fabrice] Fabrice Desré]

I encountered this error on current m-c:
[JavaScript Error: ""toString" is read-only" {file: "resource://gre/modules/osfile/osfile_unix_allthreads.jsm" line: 103}]

which makes everything else from this file fail.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

What do you mean "everything else from this file"?

Comment 2

[[:fabrice] Fabrice Desré]

well, it looks like the JS engine bails out from the function at this point, so all the object properties set afterwards are not set, etc.

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Weird.
Is that on the main thread or in a worker?

Comment 4

[[:fabrice] Fabrice Desré]

That's in the main thread.

Comment 5

[David Teller [:Yoric] - still alive but not very active]

For the moment, I cannot reproduce. Do you have logs or STR?

Comment 6

[[:fabrice] Fabrice Desré]

Attachment: patch

So it looks like importing the jsm from within a function makes things go wrong. I'm not sure which underlying changes caused that, but we can workaround for now.

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 796397 [details] [diff] [review]
patch

Review of attachment 796397 [details] [diff] [review]:
-----------------------------------------------------------------

No idea about why this happens... However, the workaround is acceptable for me.

Comment 8

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/5b4398f69062

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5b4398f69062

Comment 11

[David Teller [:Yoric] - still alive but not very active]

Fwiw, the core issue is fixed by bug 1014484.