909662 - Unchecking "Warn me when I attempt to close multiple tabs" in "Confirm close" dialog is ignored. So, "Confirm close" dialog pops up always when I close multiple tabs

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Alice0775 White]

Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/14b1e8c2957e
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130826074752

Uncheking "Warn me when I attempt to close multiple tabs" in "Confirm close" dialog is ignored. 
So, "Confirm close" dialog  pops up always when I close multiple tabs.

Steps To Reproduce:
1. Start Firefox with newly created clean profile
2. Open multiple tabs
3. Click close button on title bar
4. When "Confirm close" dialog pops up
   Turn off "Warn me when I attempt to close multiple tabs" checkbox
5. Click "Close tabs" button

6. Start Firefox again
7. Open multiple tabs
8. Click close button on title bar
   --- observe "Confirm close" dialog pops uo or not.

9. Repeat Step 6,7,8 if interested

Actual Results:
"Confirm close" dialog  pops up always.

Expected Results:
"Confirm close" dialog should not pop up after uncheck the checkbox.

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/af4e3ce8c487
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130718 Firefox/25.0 ID:20130718115206
Bad:
http://hg.mozilla.org/mozilla-central/rev/0d0263a58f06
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130718 Firefox/25.0 ID:20130718173618
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=af4e3ce8c487&tochange=0d0263a58f06

Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/353d7b3d98ef
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130717 Firefox/25.0 ID:20130717190148
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/b94553178dfe
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130717 Firefox/25.0 ID:20130717202448
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=353d7b3d98ef&tochange=b94553178dfe

Regressed by:
b94553178dfe	Jared Wein — Bug 887515 - Replace multiple tab closing prompt with a menuitem to restore multiple tabs. r=ttaubert

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

I haven't seen this before, but it might be fixed by the patch in bug 896291.

Comment 2

[tabmix.onemen]

Bug 896291 don't fix this:

Error: ReferenceError: pref is not defined
Source File: chrome://browser/content/tabbrowser.xml
Line: 1663

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to onemen.one from comment #2)
> Bug 896291 don't fix this:
> 
> Error: ReferenceError: pref is not defined
> Source File: chrome://browser/content/tabbrowser.xml
> Line: 1663

How did you get that error? I don't see a reference to a 'pref' variable within the patch for bug 896291.

Comment 4

[tabmix.onemen]

(In reply to Jared Wein [:jaws] from comment #3)
> (In reply to onemen.one from comment #2)
> > Bug 896291 don't fix this:
> > 
> > Error: ReferenceError: pref is not defined
> > Source File: chrome://browser/content/tabbrowser.xml
> > Line: 1663
> 
> How did you get that error? I don't see a reference to a 'pref' variable
> within the patch for bug 896291.

Bug 887515 removed the declaration for pref, and i don't see that bug 896291 add it back.
>-    const pref = aCloseTabs == this.closingTabsEnum.ALL ?
>-                 "browser.tabs.warnOnClose" : "browser.tabs.warnOnCloseOtherTabs"

to reproduce the error:
1. open 2 windows.
2. in the 2nd windows open few tabs
3. set browser.tabs.warnOnClose to true
4. close the 2nd window
5. un-check the checkbox warn me when... and confirm the close

result:
1. window closed as expected
2. you will the the error message in the console
3. browser.tabs.warnOnClose is still true instead of false

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Thanks oneman for the great STR

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 796182 [details] [diff] [review]
Patch

Review of attachment 796182 [details] [diff] [review]:
-----------------------------------------------------------------

Oops, yeah.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/cd2bf2d5bb00

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 796182 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 887515
User impact if declined: Choice for "Warn me when I attempt to close multiple tabs" not respected
Testing completed (on m-c, etc.): locally, just landed on fx-team
Risk to taking this patch (and alternatives if risky): none expected
String or IDL/UUID changes made by this patch: none

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cd2bf2d5bb00

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/35934f1b4a45

Comment 11

[Ada [:adalucinet]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:25.0) Gecko/20100101 Firefox/25.0 
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:26.0) Gecko/20100101 Firefox/26.0 
Mozilla/5.0 (X11; Linux i686; rv:25.0) Gecko/20100101 Firefox/25.0
Mozilla/5.0 (X11; Linux i686; rv:26.0) Gecko/20100101 Firefox/26.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20100101 Firefox/25.0
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0

Reproduced this issue with Nightly (Build ID: 20130826030203) with steps from comment 0 and comment 4.
Verified as fixed with latest Aurora 25.0a2 (Build ID: 20130911004006) and Nightly 26.0a1 (Build ID: 20130910030254).

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

Backed out of Firefox 25 by bug 914258.