909708 - [CONTACTS] On Export contacts "To SIM" option is active when there isn't a SIM card in the device.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[b.paloma]

Attachment: 2013-08-27-12-20-41.png

Repro:

1. Turn the device on without a SIM Card
2. Go to Contacts -> Settings -> Export contacts

Expected:

"SIM card" button is disabled.

Actual:

"SIM card" button is enabled.

Notes:
This bug has been checked on:
branch: master
Gaia:43cf923
Gecko:7dc9265

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 11991

Comment 2

[Jose Manuel Cantera]

Hi Francisco,

I cannot give the r+ to this bug because the message that appears when there is no SIM Card is incorrect. It should say 'To export instead of 'To import'

thanks, best

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Thanks Jose, just fixed it, as we were using the old l10n string, just updated the code.

Comment 4

[Jose Manuel Cantera]

Comment on attachment 800778 [details]
Pointer to PR 11991

now working perfectly

thanks!

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/af742a731b82cc8ecd96a7c668dac10f6baacd4f

Comment 6

[isabelrios]

Verified with unagi master 09/11 build:
Gecko-fe76476
Gaia-cfcea74
If the device does not have SIM card or SD Card or both, the options appear disabled.