Closed Bug 909767 Opened 8 years ago Closed 8 years ago

clean up mobile_config.py

Categories

(Infrastructure & Operations Graveyard :: CIDuty, task)

x86
macOS
task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kmoir, Assigned: kmoir)

Details

Attachments

(2 files)

There are many pep8 errors in this file.  Also, it could be cleaned up to make the assignment of test suites additive rather than subtractive, and thus easier to read.
Assignee: nobody → kmoir
Tested in staging
Attachment #799556 - Flags: review?(pmoore)
Comment on attachment 799556 [details] [diff] [review]
pep8 compliant mobile_config.py patches

cancelling the review, I incorporated the patches for pep8 compliance in bug 829211
Attachment #799556 - Flags: review?(pmoore)
Attached patch patchSplinter Review
patches to fix some pep8 violations but not all

aki said on an another bug that we shouldn't fix all the line length ones because it makes the code less readable
Attachment #8401414 - Flags: review?(armenzg)
Attachment #8401414 - Flags: review?(armenzg) → review+
Attachment #8401414 - Flags: checked-in+
Live in production.
fixed
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: Platform Support → Buildduty
Product: Release Engineering → Infrastructure & Operations
Product: Infrastructure & Operations → Infrastructure & Operations Graveyard
You need to log in before you can comment on or make changes to this bug.