Closed Bug 909927 Opened 6 years ago Closed 6 years ago
Minimize the #includes in layout/forms
No description provided.
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #796253 - Flags: review?(matspal)
Can we make nsButtonFrameRenderer::mFrame be a nsIFrame*? (and include nsIFrame.h instead of nsFrame.h)
(In reply to comment #3) > Can we make nsButtonFrameRenderer::mFrame be a nsIFrame*? > (and include nsIFrame.h instead of nsFrame.h) Yeah, but I'd rather that happen in another bug. Is that OK? This is mostly a bunch of semi-automated removals.
Sure, no problem.
Comment on attachment 796253 [details] [diff] [review] Patch (v1) r=mats >layout/forms/nsComboboxControlFrame.h Technically, I don't think you need "class nsPresState;" here because it's only used in an arg list for a method that's MOZ_OVERRIDE which implies the nsPresState type is sufficiently known for that use already. >layout/forms/nsTextControlFrame.h > #include "nsIEditor.h" It would be really nice if we could get rid of that one. It looks like it's only needed for the ValueSetter class ... is that even used? Please file follow-up bugs on s/nsFrame/nsIFrame/ and removing nsIEditor.h, unless you want to address them as additional patches here.
Attachment #796253 - Flags: review?(matspal) → review+
It is used from nsTextEditorState.cpp which is why I didn't find it at first: http://mxr.mozilla.org/mozilla-central/source/content/html/content/src/nsTextEditorState.cpp#1811 Still, I think we can un-inline its methods and get rid of nsIEditor.h
Filed bug 910237 and bug 901242. Note that the latter will not help with the size of our dependency graph.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.