Closed
Bug 910237
Opened 12 years ago
Closed 12 years ago
Get rid of the nsIEditor.h #include in nsTextControlFrame.h
Categories
(Core :: Layout, enhancement)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: ehsan.akhgari, Assigned: MatsPalmgren_bugz)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
6.05 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
Follow-up from bug 909927.
|
Reporter | |
Comment 1•12 years ago
|
||
|
Assignee | |
Comment 2•12 years ago
|
||
Your patch looks fine, r=mats on those changes.
I'd prefer this one though. I simply moved the ValueSetter class into
nsTextEditorState.cpp since it's the only consumer and I don't see that
changing anytime soon. What do you think?
Attachment #796808 -
Flags: review?(ehsan)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #796674 -
Flags: review?(matspal) → review+
|
|
Reporter | |
Comment 3•12 years ago
|
||
Comment on attachment 796808 [details] [diff] [review]
v2
Review of attachment 796808 [details] [diff] [review]:
-----------------------------------------------------------------
Yeah, this is a lot better!
Attachment #796808 -
Flags: review?(ehsan) → review+
|
|
Reporter | |
Updated•12 years ago
|
Attachment #796674 -
Attachment is obsolete: true
|
|
Reporter | |
Updated•12 years ago
|
Assignee: ehsan → matspal
|
|
Assignee | |
Comment 4•12 years ago
|
||
Severity: normal → enhancement
Flags: in-testsuite-
OS: Mac OS X → All
Hardware: x86 → All
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•