Closed Bug 910237 Opened 7 years ago Closed 7 years ago

Get rid of the nsIEditor.h #include in nsTextControlFrame.h

Categories

(Core :: Layout, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: ehsan, Assigned: mats)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Follow-up from bug 909927.
Attached patch Patch (v1) (obsolete) — Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #796674 - Flags: review?(matspal)
Attached patch v2Splinter Review
Your patch looks fine, r=mats on those changes.

I'd prefer this one though.  I simply moved the ValueSetter class into
nsTextEditorState.cpp since it's the only consumer and I don't see that
changing anytime soon.  What do you think?
Attachment #796808 - Flags: review?(ehsan)
Attachment #796674 - Flags: review?(matspal) → review+
Comment on attachment 796808 [details] [diff] [review]
v2

Review of attachment 796808 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, this is a lot better!
Attachment #796808 - Flags: review?(ehsan) → review+
Attachment #796674 - Attachment is obsolete: true
Assignee: ehsan → matspal
https://hg.mozilla.org/integration/mozilla-inbound/rev/92b0f1956f2b
Severity: normal → enhancement
Flags: in-testsuite-
OS: Mac OS X → All
Hardware: x86 → All
https://hg.mozilla.org/mozilla-central/rev/92b0f1956f2b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.