909971 - Remove nsThreadUtils.h include from BindingUtils.h

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrew McCreight [:mccr8]]

This is only used for NS_IsMainThread() in various binding .cpp files, but right now other things that include BindingUtils.h are going to get it, which is less than ideal.

bz's comments from bug 904826:

(In reply to Boris Zbarsky [:bz] from comment #23)
> We're going to need this for any .cpp file with non-worker descriptors that
> have any methods or attributes, and for any file with chromeonly stuff, and
> any file with a dictionary.  Followup for narrowing this down further is
> fine, especially because it'll be easier once bug 909639 lands.

(In reply to Boris Zbarsky [:bz] from comment #24)
> Actually, the other simple option is to throw this into the always-included
> headers in codegen and thus hide from non-codegen includers of BindingUtils.
> The only issue with that is that it'll conflict with bug 909639.

Comment 1

[Andrew McCreight [:mccr8]]

With bug 913847, this will be MainThreadUtils.h instead that can be removed

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Yeah, and MainThreadUtils.h is very cheap to include, so once bug 913847 lands, maybe this won't be a big deal anymore. But it's always nice to make BindingUtils.h smaller.

Comment 3

[Mathias De Maré]

Attachment: bug909971.patch

I wanted to try to solve the issues resulting from removing the MainThreadUtils.h include, so I removed it.
However, I was able to complete the build and start it without issue.

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Pushed to try to make sure that that builds on all platforms:
https://tbpl.mozilla.org/?tree=Try&rev=3beae4433356

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

Green, landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/52e65fd22097

Comment 6

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/mozilla-central/rev/52e65fd22097