910134 - generate nexus4 builds for B2G

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Please generate nightly builds for nexus4 devices. 

open questions: 

0) what branches are these supported on? I'd guess gecko m-c/gaia master only.

1) do we also need per-checkin builds? I'd guess we should generate nexus4 builds on same cadence as we do for other devices, but asking here in case needs are different.

2) if we need to generate updates? If yes, how to make these updates available without complicating updates being generated for other devices.

3) what locales are to be included? 

(blocked on getting build instructions and legal info: see dep bugs)

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to John O'Duinn [:joduinn] from comment #0)
> Please generate nightly builds for nexus4 devices. 
> 
> open questions: 
> 
> 0) what branches are these supported on? I'd guess gecko m-c/gaia master
> only.

m-c/gaia as was always discussed.

> 1) do we also need per-checkin builds? I'd guess we should generate nexus4
> builds on same cadence as we do for other devices, but asking here in case
> needs are different.

Don't know -- I would start with making just once a day nightly builds available.

> 2) if we need to generate updates? If yes, how to make these updates
> available without complicating updates being generated for other devices.
> 
> 3) what locales are to be included? 

If you ask me, no updates, and only en-US initially.  I would not block on doing anything beyond that for now.

Comment 2

[Tony Chung [:tchung]]

(In reply to Vladimir Vukicevic [:vlad] [:vladv] from comment #1)
> (In reply to John O'Duinn [:joduinn] from comment #0)
> > Please generate nightly builds for nexus4 devices. 
> > 
> > open questions: 
> > 
> > 0) what branches are these supported on? I'd guess gecko m-c/gaia master
> > only.
> 
> m-c/gaia as was always discussed.
> 
> > 1) do we also need per-checkin builds? I'd guess we should generate nexus4
> > builds on same cadence as we do for other devices, but asking here in case
> > needs are different.
> 
> Don't know -- I would start with making just once a day nightly builds
> available.
> 
> > 2) if we need to generate updates? If yes, how to make these updates
> > available without complicating updates being generated for other devices.
> > 

I would want OTA updates eventually, but not on day one.   part of our smoketests covers OTA on gecko and gaia, and checking for dataloss.

> > 3) what locales are to be included? 

I request all locales.  if we're going to spend time on QA, we need localization.  but we can start with en-US first.

> 
> If you ask me, no updates, and only en-US initially.  I would not block on
> doing anything beyond that for now.

Comment 3

[Chris AtLee [:catlee]]

Attachment: nexus4.diff

we need to switch to CAF repos for nexus4 too

Comment 4

[John Hopkins (:jhopkins)]

My staging build is currently failing on:

--------
15:53:57     INFO -  Export includes file: bootable/recovery/Android.mk -- out/target/product/mako/obj/EXECUTABLES/recovery_intermediates/export_includes
15:53:57     INFO -  target Strip: recovery (out/target/product/mako/obj/EXECUTABLES/recovery_intermediates/recovery)
15:53:57     INFO -  prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.7/bin/arm-linux-androideabi-strip: /lib64/libz.so.1: no version information available (required by prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.7/bin/arm-linux-androideabi-strip)
15:53:57     INFO -  DumpPublicKey: out/target/product/mako/obj/PACKAGING/ota_keys_intermediates/keys <= build/target/product/security/testkey.x509.pem
15:53:57    ERROR -  Traceback (most recent call last):
15:53:57     INFO -    File "./build/tools/dumpkey.py", line 80, in <module>
15:53:57     INFO -      write_key(sys.argv[i], result)
15:53:57     INFO -    File "./build/tools/dumpkey.py", line 43, in write_key
15:53:57     INFO -      modulus = subprocess.check_output(["openssl", "x509", "-in", key_path, "-modulus", "-noout"])
15:53:57     INFO -  AttributeError: 'module' object has no attribute 'check_output'
15:53:57     INFO -  make: *** [out/target/product/mako/obj/PACKAGING/ota_keys_intermediates/keys] Error 1
15:53:57     INFO -  make: *** Deleting file `out/target/product/mako/obj/PACKAGING/ota_keys_intermediates/keys'
15:53:57     INFO -  real	90m56.777s
15:53:57     INFO -  user	75m44.342s
15:53:57     INFO -  sys	7m26.021s
15:53:57     INFO -  
15:53:57     INFO -  > Build failed! <
15:53:57     INFO -  Build with |./build.sh -j1| for better messages
15:53:57     INFO -  If all else fails, use |rm -rf objdir-gecko| to clobber gecko and |rm -rf out| to clobber everything else.
15:53:57    ERROR - Return code: 2
--------

subprocess.check_output requires Python 2.7 but we're using Python 2.6.6.  I'll check whether adding /tools/python27/bin/ (binary name: python2.7) to the PATH resolves it.

Comment 5

[John Hopkins (:jhopkins)]

The plan is to rebuild the mozilla-python27 RPMs (32+64bit) to create a symlink from python -> python2.7 and update the PATH to include /tools/python27/bin/.

Comment 6

[John Hopkins (:jhopkins)]

Attachment: [buildbot-configs] add nexus-4

Comment 7

[John Hopkins (:jhopkins)]

Attachment: [mozilla-central] add mako config for nexus-4

Comment 8

[John Hopkins (:jhopkins)]

Attachment: [buildbot-configs] add nexus-4

Comment 9

[Chris AtLee [:catlee]]

Comment on attachment 803103 [details] [diff] [review]
[mozilla-central] add mako config for nexus-4

Review of attachment 803103 [details] [diff] [review]:
-----------------------------------------------------------------

If we need this for B2G 1.2, we'll need to adjust these patches after next week's uplift to mozilla-aurora.

Comment 10

[Chris AtLee [:catlee]]

Comment on attachment 803937 [details] [diff] [review]
[buildbot-configs] add nexus-4

Review of attachment 803937 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla/b2g_config.py
@@ +1179,5 @@
>          del BRANCHES[branch]['platforms']['hamachi_eng']
>  
> +# MERGE DAY: nexus-4 is only for m-c, b2g-inbound
> +for branch in BRANCHES:
> +    if branch not in ('mozilla-central', 'b2g-inbound') and \

it should be added to try as well I think. When you do that, make sure you override the slaves so that try nexus-4 builds use TRY_SLAVES['mock']

Comment 11

[Chris AtLee [:catlee]]

Comment on attachment 803937 [details] [diff] [review]
[buildbot-configs] add nexus-4

chatted with jhopkins on irc.

we can land this patch as-is for now. we're not sure about the legal restrictions around distributing these builds yet, so can't enable them on try.

Comment 12

[John Hopkins (:jhopkins)]

Comment on attachment 803103 [details] [diff] [review]
[mozilla-central] add mako config for nexus-4

https://hg.mozilla.org/mozilla-central/rev/4a3509325a0f

Comment 13

[John Hopkins (:jhopkins)]

Comment on attachment 803937 [details] [diff] [review]
[buildbot-configs] add nexus-4

https://hg.mozilla.org/build/buildbot-configs/rev/915e17a1892f

Comment 14

[John Hopkins (:jhopkins)]

The above changes to enable nexus-4 builds are complete and scheduled to go into production at 1:00PM Eastern time (10AM Pacific) today.

Important note: Builds will remain private and Try builds cannot be enabled until bug 910131 is resolved.

Comment 15

[Dale Harvey (:daleharvey)]

Sweet, whereabouts are these builds available?

Comment 16

[John Hopkins (:jhopkins)]

Details sent to :daleharvey out of band.

Comment 17

[Vlad Filippov (:vladikoff)]

Are these builds public? Is there a reason to keep the build private?

Comment 18

[ying.xu]

We meet a problem with nexus4:
The phone can not boot into homescreen app.

Checking log we found:

W/AudioSystem(  179): AudioPolicyService not published, waiting...
I/ServiceManager(  179): Waiting for service media.audio_policy...

Can you people confirm this ?

Comment 19

[John Hopkins (:jhopkins)]

(In reply to Vlad Filippov from comment #17)
> Are these builds public? Is there a reason to keep the build private?

Hi, Vlad.  The answer to that is being discussed in bug 910131.  I will try and get an updated status.

Comment 20

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

They're private at the moment because we do not have permission to redistribute the binary driver blobs.  We may have a solution soon though (sort of an "assemble your own b2g" kit).

Comment 21

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

The dependent legal bug#910131 is resolved, with some orthogonal work spun out into bug#933017.

RelEng builds have been running and generated to pvtbuilds since Sept, so all work here done, hence resolving FIXED. 

If there's anything missing from these nexus4 builds, please reopen with details.
If there's new build requests, after bug#933017 is resolved, please file new bugs for those new builds.