Closed Bug 910138 Opened 7 years ago Closed 4 years ago

Add support for new canvas ellipse method.

Categories

(Core :: Canvas: 2D, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: dongseong.hwang, Assigned: ethlin)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete, Whiteboard: [parity-blink][parity-edge])

Attachments

(3 files, 2 obsolete files)

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/30.0.1599.14 Safari/537.36

Steps to reproduce:

Canvas v5 API adds a new path segment type: ellipse.
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-context-2d-ellipse


Actual results:

Firefox does not support canvas ellipse


Expected results:

Firefox should support canvas ellipse
Recently, Blink supports canvas ellipse. https://code.google.com/p/chromium/issues/detail?id=130260

WebKit works in progress about it. https://bugs.webkit.org/show_bug.cgi?id=82791
Component: Untriaged → Canvas: 2D
OS: Linux → All
Product: Firefox → Core
Severity: normal → enhancement
Assignee: nobody → sanctity.tawdriest.stephen
Duplicate of this bug: 1067039
Status: UNCONFIRMED → NEW
Ever confirmed: true
Docs in need of updating when this gets fixed: https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D.ellipse

Also removing assignee as there has been no activity in one year.
Assignee: sanctity.tawdriest.stephen → nobody
Keywords: dev-doc-needed
Hardware: x86_64 → All
Whiteboard: [parity-blink]
Whiteboard: [parity-blink] → [parity-blink][parity-edge]
Assignee: nobody → ethlin
Attached patch Part1. Implement canvas ellipse (obsolete) — Splinter Review
Implement the ellipse method for canvas.
Attachment #8692275 - Flags: review?(roc)
Attached patch Part2. Add test case for ellipse (obsolete) — Splinter Review
Add test cases for ellipse.
Attachment #8692276 - Flags: review?(roc)
Comment on attachment 8692275 [details] [diff] [review]
Part1. Implement canvas ellipse

Review of attachment 8692275 [details] [diff] [review]:
-----------------------------------------------------------------

Needs DOM peer review for WebIDL change (though it's trivial)
Attachment #8692275 - Flags: review?(roc)
Attachment #8692275 - Flags: review?(bugs)
Attachment #8692275 - Flags: review+
Comment on attachment 8692276 [details] [diff] [review]
Part2. Add test case for ellipse

Review of attachment 8692276 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8692276 - Flags: review?(roc) → review+
Comment on attachment 8692275 [details] [diff] [review]
Part1. Implement canvas ellipse

The spec has
void ellipse(unrestricted double x, unrestricted double y, unrestricted double radiusX, unrestricted double radiusY, unrestricted double rotation, unrestricted double startAngle, unrestricted double endAngle, optional boolean anticlockwise = false)

But I guess since we don't have unrestricted in other cases either this is fine for now.
Attachment #8692275 - Flags: review?(bugs) → review+
Rebase to master.
Attachment #8692275 - Attachment is obsolete: true
Rebase to master.
Attachment #8692276 - Attachment is obsolete: true
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.