910138 - Add support for new canvas ellipse method.

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, enhancement)

Description

[Dongseong Hwang]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/30.0.1599.14 Safari/537.36

Steps to reproduce:

Canvas v5 API adds a new path segment type: ellipse.
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-context-2d-ellipse


Actual results:

Firefox does not support canvas ellipse


Expected results:

Firefox should support canvas ellipse

Comment 1

[Dongseong Hwang]

Recently, Blink supports canvas ellipse. https://code.google.com/p/chromium/issues/detail?id=130260

WebKit works in progress about it. https://bugs.webkit.org/show_bug.cgi?id=82791

Comment 3

[Florian Scholz (Open Web Docs)]

Docs in need of updating when this gets fixed: https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D.ellipse

Also removing assignee as there has been no activity in one year.

Comment 4

[Ethan Lin[:ethlin]]

Attachment: Part1. Implement canvas ellipse

Implement the ellipse method for canvas.

Comment 5

[Ethan Lin[:ethlin]]

Attachment: Part2. Add test case for ellipse

Add test cases for ellipse.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8692275 [details] [diff] [review]
Part1. Implement canvas ellipse

Review of attachment 8692275 [details] [diff] [review]:
-----------------------------------------------------------------

Needs DOM peer review for WebIDL change (though it's trivial)

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8692276 [details] [diff] [review]
Part2. Add test case for ellipse

Review of attachment 8692276 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8692275 [details] [diff] [review]
Part1. Implement canvas ellipse

The spec has
void ellipse(unrestricted double x, unrestricted double y, unrestricted double radiusX, unrestricted double radiusY, unrestricted double rotation, unrestricted double startAngle, unrestricted double endAngle, optional boolean anticlockwise = false)

But I guess since we don't have unrestricted in other cases either this is fine for now.

Comment 9

[Ethan Lin[:ethlin]]

Attachment: Part1. Implement canvas ellipse (carry r+: roc, bugs)

Rebase to master.

Comment 10

[Ethan Lin[:ethlin]]

Attachment: Part2. Add test case for ellipse (carry r+: roc)

Rebase to master.

Comment 11

[Ethan Lin[:ethlin]]

try server result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=49f13b765944&selectedJob=18075591

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1a5af4e551d4
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a779ce8d970

Comment 13

[James Graham [:jgraham]]

Attachment: wpt-metadata.diff

Comment 14

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f9b65538a2e6

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1a5af4e551d4
https://hg.mozilla.org/mozilla-central/rev/0a779ce8d970
https://hg.mozilla.org/mozilla-central/rev/f9b65538a2e6

Comment 16

[Florian Scholz (Open Web Docs)]

https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/ellipse
https://developer.mozilla.org/en-US/Firefox/Releases/48#Canvas_2D

Comment 17

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f38b9ee425e1

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f38b9ee425e1