910251 - Support LOCAL_INCLUDES in moz.build

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Gregory Szorc [:gps]]

Comment on attachment 796672 [details] [diff] [review]
Patch v1

Review of attachment 796672 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/frontend/sandbox_symbols.py
@@ +215,5 @@
>          Implies MOZILLA_INTERNAL_API.
>          """),
>  
> +    'LOCAL_INCLUDES': (StrictOrderingOnAppendList, list, [],
> +        """Something something includes.

Please fix.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Gregory Szorc [:gps] from comment #1)
> Comment on attachment 796672 [details] [diff] [review]
> Patch v1
> 
> Review of attachment 796672 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: python/mozbuild/mozbuild/frontend/sandbox_symbols.py
> @@ +215,5 @@
> >          Implies MOZILLA_INTERNAL_API.
> >          """),
> >  
> > +    'LOCAL_INCLUDES': (StrictOrderingOnAppendList, list, [],
> > +        """Something something includes.
> 
> Please fix.

You don't happen to have a good writeup? :)

Comment 3

[(not currently active) Ted Mielczarek]

"Additional directories to be searched for include files by the compiler."

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/f6b8188dfed9