Closed Bug 910251 Opened 7 years ago Closed 7 years ago

Support LOCAL_INCLUDES in moz.build

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla26

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
No description provided.
Attachment #796672 - Flags: review?(gps)
Blocks: 910253
Comment on attachment 796672 [details] [diff] [review]
Patch v1

Review of attachment 796672 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/frontend/sandbox_symbols.py
@@ +215,5 @@
>          Implies MOZILLA_INTERNAL_API.
>          """),
>  
> +    'LOCAL_INCLUDES': (StrictOrderingOnAppendList, list, [],
> +        """Something something includes.

Please fix.
Attachment #796672 - Flags: review?(gps) → review+
(In reply to Gregory Szorc [:gps] from comment #1)
> Comment on attachment 796672 [details] [diff] [review]
> Patch v1
> 
> Review of attachment 796672 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: python/mozbuild/mozbuild/frontend/sandbox_symbols.py
> @@ +215,5 @@
> >          Implies MOZILLA_INTERNAL_API.
> >          """),
> >  
> > +    'LOCAL_INCLUDES': (StrictOrderingOnAppendList, list, [],
> > +        """Something something includes.
> 
> Please fix.

You don't happen to have a good writeup? :)
Flags: needinfo?(gps)
Flags: needinfo?(gps)
"Additional directories to be searched for include files by the compiler."
https://hg.mozilla.org/mozilla-central/rev/f6b8188dfed9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.