Closed Bug 880254 Opened 9 years ago Closed 8 years ago

Move LOCAL_INCLUDES to moz.build

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: joey, Assigned: ehsan.akhgari)

References

(Blocks 1 open bug)

Details

(Keywords: meta)

Attachments

(1 file)

No description provided.
I was thinking about this at some point, and I believe we should not directly port the contents of LOCAL_INCLUDES, but have the contents of LOCAL_INCLUDES specify paths which the backend can translate into compiler include statements. So if a Makefile had something like:

LOCAL_INCLUDES += -I$(srcdir)/abc -I$(topsrcdir)/xyz

we could translate that into:
LOCAL_INCLUDES += [
    'abc',
    '/xyz',
    ]
Depends on: 881446
No longer depends on: 881446
No longer depends on: 880246
Assignee: nobody → Ms2ger
Depends on: 910251
Depends on: 910253
Keywords: meta
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #1)
> I was thinking about this at some point, and I believe we should not
> directly port the contents of LOCAL_INCLUDES, but have the contents of
> LOCAL_INCLUDES specify paths which the backend can translate into compiler
> include statements. So if a Makefile had something like:
> 
> LOCAL_INCLUDES += -I$(srcdir)/abc -I$(topsrcdir)/xyz
> 
> we could translate that into:
> LOCAL_INCLUDES += [
>     'abc',
>     '/xyz',
>     ]

One problem with this approach is that currently LOCAL_INCLUDES is used for both local includes and other system include paths that come from pkg-config for example. If we split those uses out separately then this would work.
That's a good point. Do we have any system include paths we're using like this that we couldn't simply pass globally?
Depends on: 931404
Depends on: 931459
Depends on: 931461
Depends on: 931462
Depends on: 937224
Depends on: 950130
This is fixed now, right?
After bug 968631, BXR says there are 81 cases left.
Depends on: 968631
Depends on: 968856
Depends on: 968900
Depends on: 973391
I think ehsan owns this now :)
Assignee: Ms2ger → ehsan
I'm not planning to do any work inside this bug, and don't think keeping track of things in multiple places makes sense.  For the curious, follow along in bug 928196.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INCOMPLETE
Whiteboard: [leave open]
Blocks: 1146573
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.