910311 - Improve filter fallback mechanism in Collections API

Status: RESOLVED FIXED

(Marketplace Graveyard :: API, defect, P2)

Description

[Mathieu Pillard [:mat]]

Per https://bugzilla.mozilla.org/show_bug.cgi?id=906868#c1 the fallback should be:

1. Carrier-Region-Category
2. Carrier-Category
3. Region-Category
3. Category

We currently have:

1. Carrier-Region-Category
2. Region-Category
3. Category

Comment 1

[Matt Basta [:basta]]

From 912838:

We should never show a more specific featured app collection for a more generic query. For instance:

  US, Sprint, Homepage

should only return FACs that match any of the following criteria:

- US Sprint Homepage
- Null Sprint Homepage
- US Null Homepage
- Null Null Homepage

We should never show FACs for other carriers or other regions. So for instance, a FAC with the following fields:

- CO Sprint Homepage

should never be returned for US Sprint Homepage.

Additionally, we should opt to show no featured apps if no FAC is available.

Comment 2

[Mathieu Pillard [:mat]]

So, I think what you are saying is just to disable the fallback mechanism __for featured apps__. Because we already include NULL conditions in all our queries, so when you do:

US, Sprint, Homepage

it gets translated into (region = us or NULL) and (carrier = sprint or NULL) and (category = homepage)

Is that right ? Disabling the fallback for FAC should be simple to implement (do we want this in rocketfuel filtering as well, or just featured search endpoint ?)

Comment 3

[Matt Basta [:basta]]

Yeah, that sounds about right. With the following stipulations:

- Only one FAC should be returned
- The most specific FAC should be returned
- If there's a tie, roll a D20 for strength

Comment 4

[Mathieu Pillard [:mat]]

PR: https://github.com/mozilla/zamboni/pull/1102

Comment 5

[Mathieu Pillard [:mat]]

This is fixed in https://github.com/mozilla/zamboni/commit/5984b5cc39acc3bf499e0605b57731a4a4cdd233

I'll let basta verify that the changes matches what he had in mind. There are 3 changes:
- Limit to the number of Collections returned for featured search (see comment #3)
- Disable fallback for featured apps collections in search/featured (see comment #1, comment #2 and comment #3)
- Implement the full fallback mechanism for filtering collections (see comment #0)