Closed Bug 910618 Opened 10 years ago Closed 10 years ago

[MP] Defect - Download button doesn't reflect real download's status after canceling a download

Categories

(Firefox for Metro Graveyard :: Downloads, defect, P2)

Product:
Firefox for Metro Graveyard
Component:
Downloads
Platform:
All
Windows 8.1
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Firefox 26

People

(Reporter: flod, Assigned: emtwo)

References

Details

(Whiteboard: [preview] feature=defect c=downloads_app_bar u=metro_firefox_user p=1)

Attachments

(1 file)

v1: Clear progress on download cancel and on interaction with infobar
4.72 KB, patch
jimm
: review+
Details | Diff | Splinter Review 
Firefox 2013-08-28 on Windows 8 Professional 64bit

Open Firefox, download button is inactive.

Try to download a large file, select save and then abort the download after a few seconds.
ftp://ftp.mozilla.org/pub/mozilla.org/firefox/releases/23.0.1/mac/en-US/Firefox%2023.0.1.dmg

Button doesn't return to inactive but keeps the partial blue border until a new download is started.
Blocks: metrov1backlog
Summary: Download button doesn't reflect real download's status after canceling a download → Defect - Download button doesn't reflect real download's status after canceling a download
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0
Blocks: MetroPreviewRelease
Summary: Defect - Download button doesn't reflect real download's status after canceling a download → [MP] Defect - Download button doesn't reflect real download's status after canceling a download
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0 → [preview] feature=defect c=tbd u=tbd p=0
This bug is a regression from bug 905640. I accidentally took out the calls to clear the progress when a download is cancelled so I put them back in in this patch.

I also made a change so that closing the download-complete bar clears the progress circle (instead of on download complete) as Yuan recommended in bug 905640.
Attachment #802440 - Flags: review?(jmathies)
Assignee: nobody → msamuel
Hi Marina, can you provide a point estimate for this defect.
Flags: needinfo?(msamuel)
(In reply to Marina Samuel [:emtwo] from comment #1)
> Created attachment 802440 [details] [diff] [review]
> v1: Clear progress on download cancel and on interaction with infobar
> 
> This bug is a regression from bug 905640. I accidentally took out the calls
> to clear the progress when a download is cancelled so I put them back in in
> this patch.

I thought we did that on purpose. If you cancel a download midstream are we left with a half filled circular progress meter that never goes away?
> I thought we did that on purpose. If you cancel a download midstream are we
> left with a half filled circular progress meter that never goes away?

Yes, prior to this patch, a cancelled download will leave the progress meter partway filled but I believe we want to clear the circular progress when we cancel.
p=1
Flags: needinfo?(msamuel)
Attachment #802440 - Flags: review?(jmathies) → review+
Blocks: metrov1it15
No longer blocks: metrov1backlog
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: jbecerra
Whiteboard: [preview] feature=defect c=tbd u=tbd p=0 → [preview] feature=defect c=tbd u=tbd p=1
Whiteboard: [preview] feature=defect c=tbd u=tbd p=1 → [fixed-in-fx-team][preview] feature=defect c=tbd u=tbd p=1
https://hg.mozilla.org/mozilla-central/rev/35a772328e24
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][preview] feature=defect c=tbd u=tbd p=1 → [preview] feature=defect c=tbd u=tbd p=1
Target Milestone: --- → Firefox 26
Whiteboard: [preview] feature=defect c=tbd u=tbd p=1 → [preview] feature=defect c=downloads_app_bar u=metro_firefox_user p=1
Blocks: 898477
Verified as fixed with latest Nightly, for iteration #15, on both Win 8 32-bit and 64-bit, following the STR from comment 0.
Status: RESOLVED → VERIFIED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.