910638 - Allow passing --with-intl-api to top-level configure.

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jacek Caban]

Attachment: patch.diff

ICU build system has tricky cross compiling support. It requires to build host tools before configuring target compilation. The way it's handled in Mozilla build system makes this hard to support. It has also other problems like assuming that Windows target is using MSVC in Mozilla configure, but that's an easier part.

Before that's fixed, I need a way to disable ICU compilation on mingw builds. I can imagine that such flags may be useful for others as well.

The attached patch builds on try:
https://tbpl.mozilla.org/?tree=Try&rev=6257034768f4

Comment 1

[Mike Hommey [:glandium]]

Comment on attachment 797121 [details] [diff] [review]
patch.diff

Review of attachment 797121 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +9483,5 @@
> +    but doesn't use ICU or expose the API to script.  The third doesn't build
> +    ICU at all.],
> +    WITH_INTL="--with-intl-api=$withval"
> +])
> +if test -z $WITH_INTL; then

"$WITH_INTL"

Comment 2

[Jacek Caban]

Thanks for review, pushed to m-i:

https://hg.mozilla.org/integration/mozilla-inbound/rev/afcc9a2bd94c

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/afcc9a2bd94c