Allow passing --with-intl-api to top-level configure.

RESOLVED FIXED in mozilla26

Status

RESOLVED FIXED
5 years ago
10 months ago

People

(Reporter: jacek, Assigned: jacek)

Tracking

unspecified
mozilla26
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 797121 [details] [diff] [review]
patch.diff

ICU build system has tricky cross compiling support. It requires to build host tools before configuring target compilation. The way it's handled in Mozilla build system makes this hard to support. It has also other problems like assuming that Windows target is using MSVC in Mozilla configure, but that's an easier part.

Before that's fixed, I need a way to disable ICU compilation on mingw builds. I can imagine that such flags may be useful for others as well.

The attached patch builds on try:
https://tbpl.mozilla.org/?tree=Try&rev=6257034768f4
Attachment #797121 - Flags: review?(mh+mozilla)
Comment on attachment 797121 [details] [diff] [review]
patch.diff

Review of attachment 797121 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +9483,5 @@
> +    but doesn't use ICU or expose the API to script.  The third doesn't build
> +    ICU at all.],
> +    WITH_INTL="--with-intl-api=$withval"
> +])
> +if test -z $WITH_INTL; then

"$WITH_INTL"
Attachment #797121 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 2

5 years ago
Thanks for review, pushed to m-i:

https://hg.mozilla.org/integration/mozilla-inbound/rev/afcc9a2bd94c
https://hg.mozilla.org/mozilla-central/rev/afcc9a2bd94c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Depends on: 934119

Updated

10 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.