Closed Bug 934119 Opened 10 years ago Closed 10 years ago

syntax error in configure during ./config.status --recheck

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla28

People

(Reporter: froydnj, Unassigned)

References

Details

Attachments

(1 file)

fix syntax error for definition of --with-intl-api that manifests during ./config.status --recheck
1.09 KB, patch
froydnj
: review+
Details | Diff | Splinter Review 
Doing a ./config.status --recheck, I get:

/home/froydnj/src/mozilla-central-official/configure: 29362: /home/froydnj/src/mozilla-central-official/configure: ]: not found

which comes from:

http://mxr.mozilla.org/mozilla-central/source/configure.in#9125

which has an extra ]:

http://mxr.mozilla.org/mozilla-central/source/configure.in#9132

Going to attach a patch and check this in as r=trivial.
The closing ] is actually two lines up.  Guess we have a lot of people just doing
full clobbers...
Attachment #826312 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/9e822dee6c64
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.