910707 - Bottom toolbar not visible on Nexus 4

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Dale Harvey (:daleharvey)]

The default apps (phone, sms, contacts, browser) on the bottom of the homescreen are not visible when flashing master to the nexus 4

Comment 1

[Douglas Crosher [:dougc]]

It is possible to access the browser by entering 'browser' in the search box,
but attempts to add it to the home screen give the following error:

'The page at app://homescreen.gaiamobile.org says: Browser was already added
to Home Screen'

Comment 2

[Dietrich Ayala (:dietrich)]

Who's the right person to look into this?

Comment 3

[Dale Harvey (:daleharvey)]

I am now seeing this on peak builds, so looking like a HD problem, got any ideas KM?

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Can't reproduce on nightly.. Maybe I need a true devices.
(From the spec I suppose nexus 4 should use dppx=2 with 360x640 css pixels in resolution)
Not claning the needinfo for tracing.

Comment 5

[Dietrich Ayala (:dietrich)]

I'm seeing this still on Nexus 4. Rexboy, maybe someone in the office has similar size screen could try on?

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

On my Nexus 4 build from last week, the bottom bar is now visible because the home soft-button was removed.  Instead, a swipe-up-from-bottom-edge gesture appeared to be available, acting like a single-press on the home button.  (There didn't seem to be a way to approximate long-press.)  This may have changed again; I've been a bit gun-shy about updating my build because of the tree breakage going on.

Comment 7

[Askeing Yen[:askeing][:fyen]]

v1.2 Nexus 4 still has this issue today.
  Gaia:     1e9470b9b6df630eddf1c4c8b25b3170ee786b0e
  Gecko:    451e86c3f046ef118124320550f2bc01b406aef5

Comment 8

[Dietrich Ayala (:dietrich)]

I'm still seeing a home soft-button, and no dock. Actually, just after a "make reset-gaia" I had a dock with two icons, but after rebooting the dock was gone again :)

Comment 9

[Dietrich Ayala (:dietrich)]

OK! Found a pattern. I just did a fresh build, and had a dock after first boot. But after subsequent boots, there's only the home soft-button, and *no* dock.

Comment 10

[Dietrich Ayala (:dietrich)]

Confirmed, flashing gets the dock back for exactly that first boot, and get the home button for all boots after that.

Comment 11

[Andrew Sutherland [:asuth] (he/him)]

Bug 918874 landed recently (Sep 26th, 3:09am Pacific) on master which should change things.  Dietrich, does your build include that rev?

Comment 12

[Dietrich Ayala (:dietrich)]

Latest build gave me a dock and a soft-home-button.

However, the dock only had 2 icons. After reboot, the dock is visible, but has zero icons.

Comment 13

[Dietrich Ayala (:dietrich)]

Hi George, do you have ideas about this? Can you reproduce?

Comment 14

[(Inactive after June) George Duan [:gduan] [:喬智]]

What I see now ,when software button is enabled and displayed, the bottom docks are all gone.
I think the reason is because in homescreen.css, they use a mediaquery to hide the footer for keyboard displaying(?).
After removing that, all the docks are back with software btns. 

Let me try to fix that.

Comment 15

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Vivien,

This patch should fix the invisible dock bar and also update a better method to switch home-gesture and sft home button when initializing.

Please kindly review. 
Thanks.

Comment 17

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 812943 [details]
PR to master

I never touch this code so let's find a more appropriate reviewer.

Comment 18

[(Inactive after June) George Duan [:gduan] [:喬智]]

Hi, I download latest gaia and saw someone has removed the search bar for e.me from homescreen's first page.

Is it expected behavior?
If so, I guess we can remove all the mediaquery part of homescreen.css ? (https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/style/homescreen.css#L152 )

Comment 19

[Cristian Rodriguez (:crdlc)]

Hi,

  This was done in bug 838634 by Evyatar and reviewed by Vivien. It was during my Summer holidays then I don't have idea what is the purpose of that sadly and I cannot help you

Sorry

Comment 20

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 812943 [details]
PR to master

Please ignore comment 18, the searchbar only disappear on nightly. I think the mediaquery part in homescreen.css is not good. I will update my patch later.

Comment 21

[Dietrich Ayala (:dietrich)]

I just heard about the "enable software home button" setting, so i unchecked it to get the apps back in the dock, and filed bug 926631 and bug 926632.

George, any ETA for a solution to some of these issues?

Comment 22

[(Inactive after June) George Duan [:gduan] [:喬智]]

Sorry, I wish I can update, but currently I have no device to verify my patch. I will try to borrow one these days!

Comment 23

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 812943 [details]
PR to master

Hi Vivien and Alive,

this patch has modify homescreen.css for different device and also some logic of software_home_button.js and home_gesure.js to make sure the software home button would always display on Nexus 4 device when initializing.

could you kindly help to review this patch?

Comment 24

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 812943 [details]
PR to master

I'm fine with whatever Alive agree with.

Comment 25

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 812943 [details]
PR to master

We had done something complex here...

The right logic looks to me is
=== hasHardwareHomeButton? ===
1. Yes --> listen to settings and
   (A) Turn off SoftwareHomeButton when HomeGesture is turned on.
   (B) Turn off HomeGesture when SoftwareHomeButton is turned on.
   * SoftwareHomeButton and HomeGesture couldn't be on at the same time. (Am I right?)
2. No  -->
   (A) Automatically enable HomeGesture if we're tablet. Ignore any settings(neither read nor write nor observe change nor listen event). * Hide both the settings in Settings app.
   (B) If we're not tablet automatically enable SoftwareHomeButton and sends event to HomeGesture to turn off HomeGesture Settings. On the other hand if HomeGesture is turned on, sends event to SoftwareHomeButton to turn off SoftwareHomeButton Settings. * Hide SoftwareHomeButton settings in Settings app and display HomeGesture settings.

So, let's decouple the settings ON state and realistic ON state as

HomeGesture.ON = hasHardwareButton ? (!SoftwareButtonManager.settingsON && HomeGesture.settingsON) : (isTablet? true : (!SoftwareButtonManager.ON && HomeGesture.settingsON));

SoftwareButtonManager.ON = hasHardwareButton ? (SoftwareButtonManager.settingsON && !HomeGesture.settingsON) : (isTablet? false : (!HomeGesture.settingsON));

settingsON means the observed value in SettingsListener.observe callback.
don't try to write settings anymore because we don't need and it's annoying to have bug like 926631.

It would not be a trivial fix, if you don't want to work on please assign to me.
Let me know if you have questions about my proposal.

Comment 26

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 812943 [details]
PR to master

Hi Alive,
thanks for your advice, so we'll only enable gesture on tablet, and hide setting of software_home_button on mobile that has no hardware home button.

I update my patch as you stated in comment 25.
Please kindly check again.

Comment 27

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 812943 [details]
PR to master

You should not merge before fixing travis.

Comment 28

[(Inactive after June) George Duan [:gduan] [:喬智]]

Just checked why ui-test failed, I think it's caused by the test's own bug, and not related to my patch.

Merge into master,
https://github.com/mozilla-b2g/gaia/commit/e10553a9099545157636a057c170c77fb4cb93a5

Comment 29

[Dietrich Ayala (:dietrich)]

Thanks George and Alive!

George, were you able to fix the broken test?

Comment 30

[Dietrich Ayala (:dietrich)]

George, does your fix for this bug have an effect on bug 926631 or bug 926632?

Comment 31

[(Inactive after June) George Duan [:gduan] [:喬智]]

Yesterday I tried on Nexus 4 , it seems bug 926632 is resolved, but I didn't try to reboot it.

Currently, I just found there's another issue on inari and buri, whenever I enable the software home button and try to reboot, I cannot launch most of apps. File a new bug 929285 for it.