910741 - clicking on links in share panel does not open pages in tabs

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Shane Caraveo (:mixedpuppy)]

Links in the share panel will not open browser tabs, unlike all other social panels.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: fix link handling in share panel

Comment 2

[Shane Caraveo (:mixedpuppy)]

STR for qa

- install demo provider at http://mixedpuppy.github.io/socialapi-demo/ (updated for this bug, reinstall if using existing profile)
- open a tab to any page
- open share panel
- share panel should have serveral clickable links at the bottom, try them

expected:

new tabs will open, one link has a target and will reload in the tab for that target

what happens:

only the last link that uses window.open will work, all others fail to open tabs

Comment 3

[Shane Caraveo (:mixedpuppy)]

Attachment: fix link handling in share panel

feedback implemented per conversation with felipe

Comment 4

[u279076]

Shane, can you please provide better steps to reproduce? I can't discover a way to get clickable links to appear in the Demo Provider's share panel. It just shows the "Sharing" and "Data" text boxes and a share button. Clicking the share button adds the URL to the "Shared" section in the sidebar but this too is just a textbox.

Comment 5

[Shane Caraveo (:mixedpuppy)]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #4)
> Shane, can you please provide better steps to reproduce? I can't discover a
> way to get clickable links to appear in the Demo Provider's share panel. It
> just shows the "Sharing" and "Data" text boxes and a share button. Clicking
> the share button adds the URL to the "Shared" section in the sidebar but
> this too is just a textbox.

Try reactivating now, I didn't add some changes to my last commit.  The github pages are now properly updated.

Comment 6

[u279076]

It works now, thanks.

Comment 7

[Shane Caraveo (:mixedpuppy)]

https://hg.mozilla.org/integration/fx-team/rev/10e9f1f0b992

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

Backed out for breaking m-bc tests:

https://hg.mozilla.org/integration/fx-team/rev/d5dbccdf39fe

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_flyout.js | flyout should be closed - Got open, expected closed

Comment 9

[Shane Caraveo (:mixedpuppy)]

Attachment: fix link handling in share panel

simple fix to test

https://tbpl.mozilla.org/?tree=Try&rev=786871d9a85d

https://hg.mozilla.org/integration/fx-team/rev/c489910a28c3

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c489910a28c3

Comment 11

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 797913 [details] [diff] [review]
fix link handling in share panel

[Approval Request Comment]
Bug caused by (feature/regressing bug #): share
User impact if declined: clicking on links (meant to open pages in browser tabs) in share panel has no affect
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 12

[bhavana bajaj [:bajaj]]

Comment on attachment 797913 [details] [diff] [review]
fix link handling in share panel

low risk patch for a recent feature where the share panel does not open links in tabs as expected.

Adding qawanted to help with verification here.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/30c1ad9d217b
https://hg.mozilla.org/releases/mozilla-beta/rev/ffdce67d4bbf

Comment 14

[u279076]

(In reply to bhavana bajaj [:bajaj] from comment #12)
> Adding qawanted to help with verification here.

Please use the verifyme keyword in this case, thank you.

Comment 15

[u279076]

Verified fixed in Firefox Nightly 26.0a1 2013-09-04. Will wait for the next Aurora and Beta to verify for Firefox 25 and 24, respectively.

Comment 16

[u279076]

Verified fixed in Firefox 25.0a2 2013-09-06.
Verified fixed in Firefox 24.0b8.