Closed
Bug 910754
Opened 11 years ago
Closed 10 years ago
[Skia] Update Skia, 2014Q1
Categories
(Core :: Graphics, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: gw280, Assigned: gw280)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
Attachments
(16 files)
Let's do another Skia update. Most important new features we'd like to pull in are fixes to Skia/GL's texture cache to stop it from overrunning its cache limits, and advanced xfermodes which we'd like to use.
Comment 1•11 years ago
|
||
If this is to end up in 26, convince me we have time to do it :)
Assignee | ||
Comment 2•11 years ago
|
||
Forward port Matt's patch from bug 884888
Attachment #810838 -
Flags: review?(matt.woodrow)
Comment 3•11 years ago
|
||
Comment on attachment 810838 [details] [diff] [review] shadows.patch Review of attachment 810838 [details] [diff] [review]: ----------------------------------------------------------------- Do you need the changes to drawRect to ensure that we actually end up inside drawPath?
Attachment #810838 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Good catch. I thought I'd applied that hunk, but I guess I didn't.
Assignee | ||
Updated•10 years ago
|
Summary: [Skia] Update Skia, 2013Q3 → [Skia] Update Skia, 2014Q1
Assignee | ||
Comment 5•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Graphics&rev=bd802cd9c2d5 We are green! This is r13424 from upstream/trunk.
Assignee | ||
Comment 6•10 years ago
|
||
Attachment #8377702 -
Flags: review?(vladimir)
Assignee | ||
Comment 7•10 years ago
|
||
Attachment #8377703 -
Flags: review?(snorp)
Assignee | ||
Comment 8•10 years ago
|
||
Attachment #8377705 -
Flags: review?(snorp)
Assignee | ||
Comment 9•10 years ago
|
||
Attachment #8377706 -
Flags: review?(snorp)
Assignee | ||
Comment 10•10 years ago
|
||
Attachment #8377707 -
Flags: review?(snorp)
Assignee | ||
Comment 11•10 years ago
|
||
Attachment #8377708 -
Flags: review?(snorp)
Assignee | ||
Comment 12•10 years ago
|
||
Attachment #8377709 -
Flags: review?(snorp)
Assignee | ||
Comment 13•10 years ago
|
||
Attachment #8377711 -
Flags: review?(snorp)
Assignee | ||
Comment 14•10 years ago
|
||
Attachment #8377712 -
Flags: review?(snorp)
Assignee | ||
Comment 15•10 years ago
|
||
Attachment #8377713 -
Flags: review?(snorp)
Assignee | ||
Comment 16•10 years ago
|
||
Attachment #8377714 -
Flags: review?(snorp)
Comment on attachment 8377702 [details] [diff] [review] 0001-Bug-910754-Add-a-bunch-more-required-OpenGL-function.patch Review of attachment 8377702 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, but can you add a comment above the block of functions in the two headers saying that this is functionality needed for Skia, and should not be generally used? This stuff is not in ES2.0, it's only desktop Skia that's going to get or use this. I almost wish we could create a context and pass a flag to say "this is a context for skia" that would cause us to look up this stuff.
Attachment #8377702 -
Flags: review?(vladimir) → review+
Comment 18•10 years ago
|
||
Comment on attachment 8377703 [details] [diff] [review] 0002-Bug-910754-skia-npapi-s-anp_getFontPath-function-doe.patch Review of attachment 8377703 [details] [diff] [review]: ----------------------------------------------------------------- Are you sure we don't need this anymore? IIRC, Flash didn't work anymore without this? Did you try on 2.3 and 4.0+?
Attachment #8377703 -
Flags: review?(snorp)
Updated•10 years ago
|
Attachment #8377705 -
Flags: review?(snorp) → review+
Updated•10 years ago
|
Attachment #8377706 -
Flags: review?(snorp) → review+
Comment 19•10 years ago
|
||
Comment on attachment 8377707 [details] [diff] [review] 0006-Bug-910754-Mark-linear-gradient-1a-and-linear-gradie.patch Review of attachment 8377707 [details] [diff] [review]: ----------------------------------------------------------------- Alright I guess, but what platform was this new failing on?
Attachment #8377707 -
Flags: review?(snorp) → review+
Updated•10 years ago
|
Attachment #8377708 -
Flags: review?(snorp) → review+
Updated•10 years ago
|
Attachment #8377709 -
Flags: review?(snorp) → review+
Updated•10 years ago
|
Attachment #8377711 -
Flags: review?(snorp) → review+
Assignee | ||
Comment 20•10 years ago
|
||
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #19) > Alright I guess, but what platform was this new failing on? This was discussed between myself and jrmuizel; we decided that as other backends like Quartz etc were already failing these tests, and other browsers fail it anyway (Chrome and Safari do), we shouldn't care about it anymore.
Updated•10 years ago
|
Attachment #8377712 -
Flags: review?(snorp) → review+
Updated•10 years ago
|
Attachment #8377713 -
Flags: review?(snorp) → review+
Assignee | ||
Comment 21•10 years ago
|
||
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #18) > Are you sure we don't need this anymore? IIRC, Flash didn't work anymore > without this? Did you try on 2.3 and 4.0+? Flash works fine on 4.x with this. I can't comment on 2.x.
Updated•10 years ago
|
Attachment #8377714 -
Flags: review?(snorp) → review+
Updated•10 years ago
|
Attachment #8377703 -
Flags: review+
Assignee | ||
Comment 22•10 years ago
|
||
Attachment #8377883 -
Flags: review?(snorp)
Updated•10 years ago
|
Attachment #8377883 -
Flags: review?(snorp) → review+
Assignee | ||
Comment 23•10 years ago
|
||
The eagle has landed. I repeat, the eagle has landed. https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=f8cd1f2d686e
https://hg.mozilla.org/mozilla-central/rev/f6c2efda0788 https://hg.mozilla.org/mozilla-central/rev/5d933587c726 https://hg.mozilla.org/mozilla-central/rev/0c3c16ea5cd3 https://hg.mozilla.org/mozilla-central/rev/56474b57c3b8 https://hg.mozilla.org/mozilla-central/rev/218aa532182b https://hg.mozilla.org/mozilla-central/rev/87859a17d799 https://hg.mozilla.org/mozilla-central/rev/07dc7e2ed993 https://hg.mozilla.org/mozilla-central/rev/5498f482b7ff https://hg.mozilla.org/mozilla-central/rev/29a97babd395 https://hg.mozilla.org/mozilla-central/rev/609d3ba60b5b https://hg.mozilla.org/mozilla-central/rev/602341e2f084 https://hg.mozilla.org/mozilla-central/rev/14e857f528b2 https://hg.mozilla.org/mozilla-central/rev/29fcbc4e91f3 https://hg.mozilla.org/mozilla-central/rev/c53990676a37 https://hg.mozilla.org/mozilla-central/rev/f8cd1f2d686e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Assignee | ||
Comment 25•10 years ago
|
||
derp, I forgot to add that last moz.build fixup to the generation script :/
Attachment #8378565 -
Flags: review?(snorp)
Comment on attachment 8378565 [details] [diff] [review] mozbuild-fixup land away, include NPOTB to not trigger a build though. (NPOB? NPOT? I can never remember!)
Attachment #8378565 -
Flags: review?(snorp) → review+
Assignee | ||
Comment 27•10 years ago
|
||
DONTBUILD I think?
Assignee | ||
Comment 28•10 years ago
|
||
Add a warning header to moz.build to signify that the file shouldn't be modified directly.
Attachment #8378577 -
Flags: review?(vladimir)
Comment on attachment 8378577 [details] [diff] [review] header npotb
Attachment #8378577 -
Flags: review?(vladimir) → review+
Comment 30•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ad1d8b7022f7 https://hg.mozilla.org/mozilla-central/rev/2216fa1ce96e
Comment 31•10 years ago
|
||
This un-unified the Skia build: the UNIFIED_SOURCES in gfx/skia/moz.build were overwritten with just SOURCES. This is a big deal because skia build unification (bug 939629) shaved 1 minute cpu time off the build.
Are we using this latest skia version in Master branch now (for firefox OS platform)? Can you please confirm us ?
Flags: needinfo?(gwright)
Please also confirm future skia version update plans for v1.4 and Master (for firefox os platform) .
Flags: needinfo?(snorp)
Comment 34•10 years ago
|
||
(In reply to Tapas Kumar Kundu from comment #33) > Please also confirm future skia version update plans for v1.4 and Master > (for firefox os platform) . The version of Skia in master (and 1.4) is r13424.
Flags: needinfo?(snorp)
Assignee | ||
Comment 35•10 years ago
|
||
Future skia update plans are to pull in a new version once per train. i.e. every 6 weeks or so. I also plan to do a quick interim testing update and push to my personal branches + graphics branch once per week (tentatively on Fridays). As snorp said, current master branch is using Skia from two weeks ago (r13424).
Flags: needinfo?(gwright)
Assignee | ||
Comment 36•10 years ago
|
||
Attachment #8390473 -
Flags: review?(snorp)
Assignee | ||
Comment 37•10 years ago
|
||
For the SkMemory_mozalloc patch: https://tbpl.mozilla.org/?tree=Try&rev=8d7d0ca72815
Comment 38•10 years ago
|
||
Comment on attachment 8390473 [details] [diff] [review] 0001-Bug-910754-Use-SkMemory_mozalloc-instead-r-snorp.patch Review of attachment 8390473 [details] [diff] [review]: ----------------------------------------------------------------- I guess if we have this file in generate_mozbuild.py, future rebases will fail without it, so we don't need to upstream that.
Attachment #8390473 -
Flags: review?(snorp) → review+
Assignee | ||
Comment 39•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/beb1b8402d96
Assignee | ||
Comment 40•10 years ago
|
||
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #38) > I guess if we have this file in generate_mozbuild.py, future rebases will > fail without it, so we don't need to upstream that. SkMemory_mozalloc was upstreamed months ago :)
Updated•9 years ago
|
Blocks: skia-updates
Updated•5 years ago
|
Type: defect → enhancement
You need to log in
before you can comment on or make changes to this bug.
Description
•