1023732 - Skia update from bug 910754 left out patches

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Mike Hommey [:glandium]]

At the very least the patch gfx/skia/patches/0026-Bug-901208-Fix-ARM-v4t.patch is not applied. I haven't looked at the other patches.

Also, the change of paths without hg rename tracking breaks hg log, blame, etc. Please use hg addremove next time.

Comment 1

[George Wright (:gw280) (needinfo me!)]

That patch got lost because I was never asked for review on that bug or CCd on it, and we've since moved to an upstream-first policy where we immediately upstream any changes so we don't have to maintain a local series of patches.

Please ensure that I am kept in the loop for all Skia-related changes going forward so that I can deal with upstreaming them and avoid this issue in future.

Comment 2

[Mike Hommey [:glandium]]

(In reply to George Wright (:gw280) from comment #1)
> That patch got lost

That patch is far from being the only one that got lost (a cursory application of patches show that several still apply).

Comment 3

[George Wright (:gw280) (needinfo me!)]

(In reply to Mike Hommey [:glandium] from comment #2)
> (In reply to George Wright (:gw280) from comment #1)
> > That patch got lost
> 
> That patch is far from being the only one that got lost (a cursory
> application of patches show that several still apply).

There were only two that were still relevant (any others that may still apply have been deemed unnecessary at this point) and since I know about them I tend to take care of them before I do a skia update. Anyway, this is all beside the point - please ensure that I am at a minimum CCd on patches going into skia going forward, preferably with a review request too.

I'll sort out the patches directory to indicate that it's pretty much obsolete at this point because it's quite misleading right now.

Comment 4

[George Wright (:gw280) (needinfo me!)]

These have all been dealt with.