Skia update from bug 910754 left out patches

RESOLVED FIXED

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: glandium, Unassigned)

Tracking

(Blocks: 1 bug)

unspecified
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox30 affected, firefox31 affected, firefox32 affected)

Details

(Reporter)

Description

4 years ago
At the very least the patch gfx/skia/patches/0026-Bug-901208-Fix-ARM-v4t.patch is not applied. I haven't looked at the other patches.

Also, the change of paths without hg rename tracking breaks hg log, blame, etc. Please use hg addremove next time.
(Reporter)

Updated

4 years ago
status-firefox30: --- → affected
status-firefox31: --- → affected
status-firefox32: --- → affected
(Reporter)

Updated

4 years ago
Blocks: 1010037
(Reporter)

Updated

4 years ago
Blocks: 1017113
(Reporter)

Updated

4 years ago
Blocks: 987008
That patch got lost because I was never asked for review on that bug or CCd on it, and we've since moved to an upstream-first policy where we immediately upstream any changes so we don't have to maintain a local series of patches.

Please ensure that I am kept in the loop for all Skia-related changes going forward so that I can deal with upstreaming them and avoid this issue in future.
(Reporter)

Comment 2

4 years ago
(In reply to George Wright (:gw280) from comment #1)
> That patch got lost

That patch is far from being the only one that got lost (a cursory application of patches show that several still apply).
(In reply to Mike Hommey [:glandium] from comment #2)
> (In reply to George Wright (:gw280) from comment #1)
> > That patch got lost
> 
> That patch is far from being the only one that got lost (a cursory
> application of patches show that several still apply).

There were only two that were still relevant (any others that may still apply have been deemed unnecessary at this point) and since I know about them I tend to take care of them before I do a skia update. Anyway, this is all beside the point - please ensure that I am at a minimum CCd on patches going into skia going forward, preferably with a review request too.

I'll sort out the patches directory to indicate that it's pretty much obsolete at this point because it's quite misleading right now.
See Also: → bug 1028827
These have all been dealt with.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.