910797 - Fix Event.isTrusted handling for workers

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

"IsCaller" is a bit wrong. Should be something like "IsInChromeContext"
but that doesn't mean JSContext but the broader concept. So IsCaller for now.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 797353 [details] [diff] [review]
patch

Review of attachment 797353 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsContentUtils.cpp
@@ +1771,5 @@
> +nsContentUtils::ThreadsafeIsCallerChrome()
> +{
> +  return NS_IsMainThread() ?
> +    IsCallerChrome() :
> +    mozilla::dom::workers::IsCurrentThreadRunningChromeWorker();

Please put a big fat assertion in IsCallerChrome.

::: xpcom/base/CycleCollectedJSRuntime.h
@@ +205,5 @@
> +  JSRuntime* Runtime() const
> +  {
> +    MOZ_ASSERT(mJSRuntime);
> +    return mJSRuntime;
> +  }

You should get rid of the Runtime() methods in XPCJSRuntime and WorkerJSRuntime then.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=131e9a5efaa3

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f60c6188a889

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f60c6188a889