910844 - Allow Firefox Accounts jelly to check signed-in status and to sign out

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Zachary Carter [:zaach]]

The jelly should be able to discover the signed-in status of the browser so it can show the appropriate UI. It should also be able to sign the user out.

We'll need to add a command handler to the wrapper for getting the user's signed in status and another handler for sign out.

Comment 1

[Zachary Carter [:zaach]]

Attachment: Allow jelly to detect signed in status and sign user out

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 800285 [details] [diff] [review]
Allow jelly to detect signed in status and sign user out

Looks pretty straightforward. Fat arrows would be a bit nicer (no bind()) but I don't feel strongly.

"data" as the return value of getSignedInUser is a bit ambiguous, it might be useful to elaborate on the data being passed via these messages in a comment. 

In fact a higher-level description of messages that go back/forth and their format would be useful too. It's a bit confusing that the events in one direction have a "command" and "data", while in the other direction you have a "type" and "content" (which has a "status" and optionally "data").

Comment 3

[Zachary Carter [:zaach]]

Attachment: 910844_signedin_signout-2.patch

Comment 4

[Zachary Carter [:zaach]]

https://hg.mozilla.org/projects/elm/rev/258a0a22e62b

Comment 5

[James Bonacci [:jbonacci]]

And another!
Adding to my stack of Resolved bugs to review...
I expect the build will be on the ELM site by tomorrow morning...

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/2c939203db7a

Comment 7

[James Bonacci [:jbonacci]]

Cleaning up Resolved/Fixed bugs from December's first release.
Verified that we now have a working first-release of FxA to Desktop/Android Nightly.
Re-open as needed.