910887 - style badge details view and page

Status: RESOLVED FIXED

(support.mozilla.org :: General, defect, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Bug #896137 adds badge infrastructure to Kitsune.

We can create badges in the admin, but the award details page and awards list page should link to a Badge details page that tells you what the badge is for and the list of users it's been awarded to. Or something like that.

This bug covers:

1. figuring out what the view should do
2. implementing the view
3. figuring out what the template should look like
4. implementing the template
5. implementing a mobile template

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

Again, we can skip mobile for now.

Making this one 3pts since there is figuring out to do which probably involves reaching out Kadir, Roland, etc.

Comment 2

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #1)
> Again, we can skip mobile for now.
> 
> Making this one 3pts since there is figuring out to do which probably
> involves reaching out Kadir, Roland, etc.

hi ricky and willkg: kadir and i indeed have some figuring out to do as well as your sumo-dev figuring out. hope to do that this week and then for kadir or i to get back to you. but my blink reaction, is that this shouldn't be a blocker.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

(In reply to Roland Tanglao :rolandtanglao from comment #2)
> 
> hi ricky and willkg: kadir and i indeed have some figuring out to do as well
> as your sumo-dev figuring out. hope to do that this week and then for kadir
> or i to get back to you. but my blink reaction, is that this shouldn't be a
> blocker.

By "this shouldn't be a blocker" do you mean we shouldn't work on this now or something else? I don't understand what this shouldn't block since it doesn't block anything.

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

willkg ended up creating this badge detail page with the infrastructure bug:
https://github.com/mozilla/kitsune/commit/b3a42acdff22e2a8c1e67f20828acbe33f4c80d1#diff-7

So we just need to tweak the content and style. I am reducing to 2pts.

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

Assigning to Rehan since this is very close to the other pages he is working on.

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

Kadir requested screenshots before landing.

Comment 7

[Rehan Dalal (Inactive)]

Attachment: badge_details.png

See screenshot. Is that okay?

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

I think this looks lovely!

Comment 9

[Kadir Topal [:atopal]]

This is great, I'd just change "recent awards" to "recent awardees", to make it clear that it's a list of people who recently got that award. Thanks, Rehan!

Comment 10

[Rehan Dalal (Inactive)]

Landed:
https://github.com/mozilla/kitsune/commit/0b7183d41e77e8efcb1d0e7339cf03d5167883f4

Pushed to prod by me, right now.