Closed Bug 910898 Opened 11 years ago Closed 6 years ago

[Follow-up] Provider: failed submissions without HealthReportDatabaseStorage instance

Categories

(Android Background Services Graveyard :: Firefox Health Report Service, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: mcomella, Unassigned)

References

Details

Bug 870925 will land the submissions provider for FHR. This patch will take care of incrementing failure counts for any failures that have access to the HealthReportDatabaseStorage instance by incrementing them into storage directly. However, if we want to count all failures correctly, we must also account for when this storage instance cannot be retrieved and store these counts temporarily in the SharedPreferences until the storage instance can be retrieved and the true count incremented.

The bug above should add TODOs for these cases - fill them in.
Since we don't have the storage instance, we may not be able to get the env (and the code path to get the day may need to be separate from the current storage.getDay() or refactored). This means we can't accurately record these failures given the FHR document schema v3.

It seems important that the env is not misreported for crashes (i.e. we should not use the env from the previous/next upload attempt or the previous/next Gecko boot which seems to be the obvious way to get an env in these cases). I would propose creating a dummy env that any failures recorded without an env are registered to. Does that sound reasonable?
Flags: needinfo?(rnewman)
Well, we can get the env from the PIC, which is totally independent of storage. That doesn't help us if we crash on upgrade or in the PIC, but it covers most of the situations.

The rest… yes, we'll need to extend the format to include an unknown environment. That's a doc change…
Flags: needinfo?(rnewman)
We don't do FHR anymore.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.