Closed Bug 870925 Opened 7 years ago Closed 6 years ago
This is the Android equivalent of Bug 854018. We'll want to track upload attempts, successes, and failures. Note that this needs to compute environments outside of Fennec, so I might have to rejig some stuff.
OS: Mac OS X → Android
Priority: -- → P2
Hardware: x86 → ARM
7 years ago
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
^ needinfo is for feedback. Specifically, I would like to know if overriding the RequestDelegate to record submissions is the correct course of action for implementing a patch. Otherwise, the feedback does not need to be very thorough and can wait for the review.
Drat, wrong bug. Still reviewing this one; Bug 893910 looks good to me :D
r? - part 8 - getCacheSuffix changes as spoken about on IRC. I can move it to part 0 if you'd prefer.
r? - parts 1-14, sans part 8 and its review comment: https://github.com/mozilla-services/android-sync/pull/332 Note that upload(...) could be tested better by ensuring the Delegate passed to uploadPayload's handle* methods are called in various error cases, however, that seems like a lot of extra effort for little gain.
(In reply to Michael Comella (:mcomella) from comment #5) > r? - part 8 - getCacheSuffix changes as spoken about on IRC. I can move it > to part 0 if you'd prefer. Sorry, this slipped -- lgtm.
Have a structural comment on the PR. Otherwise looking good, I think.
No longer blocks: 902560
Attachment #819855 - Attachment description: Github PR → Add submissions provider
Comment on attachment 819855 [details] [review] Add submissions provider I made the `SubmissionsStatusCounter` changes you recommended (but yet sans testing). Is that what you were looking for?
Attachment #819855 - Flags: feedback?(rnewman)
Comment on attachment 819855 [details] [review] Add submissions provider Yeah, that's it!
Attachment #819855 - Flags: feedback?(rnewman) → feedback+
Comment on attachment 819855 [details] [review] Add submissions provider I added the tests to the refactor.
Attachment #819855 - Flags: feedback+ → review?(rnewman)
Attachment #819855 - Flags: review?(rnewman) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.