911014 - add-ons won't install with 'security.dialog_enable_delay' = 0 after bug 908304

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Gary [:streetwolf52]]

Good - http://hg.mozilla.org/integration/mozilla-inbound/rev/3e3879c8516c

Bad - http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=82ffb042ef96


Might be caused by https://bugzilla.mozilla.org/show_bug.cgi?id=908304

Comment 1

[Gary [:streetwolf52]]

Install works with a new profile.  However if I copy over my production prefs.js to the new profile installs don't work. 

Something had to change between the two csets to cause the same pref to prevent installing add-ons.  Will try to narrow it down.

Comment 2

[Gary [:streetwolf52]]

The pref causing the problem is this one:

security.dialog_enable_delay

Setting it to a value causes add-ons not to be installed.

Comment 3

[Gary [:streetwolf52]]

More specifically setting 
security.dialog_enable_delay = 0 causes the problem.  Seems you now need at least a 1 second count down.

Comment 4

[Gary [:streetwolf52]]

Actually you can set it lower than 1 second.  It appears to need a value that will bring up the count down window.

Comment 5

[:Irving Reid (No longer working on Firefox)]

Attachment: Register unload handler even when dialog delay preference is zero

Comment 6

[merfius]

Confirmed here.  

The countdown should be removed entirely.  It's more an inconvenience than a practical security measure.

Comment 7

[:Irving Reid (No longer working on Firefox)]

https://hg.mozilla.org/integration/fx-team/rev/9f30b801cfa9

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9f30b801cfa9