911022 - [e.me][feature] Enable search saving

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Ran Ben Aharon [:ranbena] EverythingMe]

In search results, when searchbar is no longer focused, a star button should appear in the helper, indicating if the search already exists as a Collection in Homescreen.
If it is not, clicking the star adds the new Collection to the Homescreen and notifies the user with a Banner.

Comment 1

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: 01_Search-Not-saved.png

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: 02_Search-Not-saved-active.png

Comment 3

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: 04_Search-Saved.png

Comment 4

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: 05_Remove-Dialogue.png

Comment 5

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Patch - redirect to commit.html

Comment 6

[Amir Nissim (:amirn)]

branch rebased onto stg-pr https://github.com/EverythingMe/gaia/commits/911022-save-search

Comment 7

[Amir Nissim (:amirn)]

Attachment: redirect to PR

Comment 8

[Cristian Rodriguez (:crdlc)]

You have some comments on github

Comment 9

[Amir Nissim (:amirn)]

(In reply to Cristian Rodriguez (:crdlc) from comment #8)
> You have some comments on github

Thanks Crisitan.
update PR: replaced callbacks with events. can you give it another look please?

Comment 10

[Cristian Rodriguez (:crdlc)]

Comment on attachment 811705 [details]
redirect to PR

Two minor comments on github. Good work as usual! Thx!

Comment 11

[Ran Ben Aharon [:ranbena] EverythingMe]

I put some comments on Github Amir

Comment 12

[Amir Nissim (:amirn)]

ready for your re-review [e-mail]

Comment 13

[Amir Nissim (:amirn)]

safely landed in master
https://github.com/mozilla-b2g/gaia/commit/41fd4bd65cc5760f1e264e8ab8b1631f5284f1a3

Comment 14

[Evyatar 'Tron' Amitay (everything.me)]

removing koi? since e.me 1.2 features are delayed for future version